Skip to content

fix: harden dbt pipeline inputs#8878

Merged
Startrekzky merged 2 commits into
mainfrom
kw-fix-dbt
May 17, 2026
Merged

fix: harden dbt pipeline inputs#8878
Startrekzky merged 2 commits into
mainfrom
kw-fix-dbt

Conversation

@klesh
Copy link
Copy Markdown
Contributor

@klesh klesh commented May 16, 2026

Summary

  • hardens dbt pipeline inputs by constraining local projectPath values to DBT_PROJECTS_DIR, rejecting unsafe git URLs, and cloning git-backed projects into managed temp directories instead of deleting caller-supplied paths
  • wires dbt conversion to depend on the git clone step and cleans up managed project directories after the task finishes
  • changes auth to default AUTH_ENABLED to true unless explicitly disabled, only require SESSION_SECRET for OIDC, and updates examples/tests to match

Does this close any open issues?

Closes N/A

Screenshots

N/A

Other Information

  • Added regression coverage in backend/plugins/dbt/tasks/options_test.go and backend/helpers/oidchelper/config_test.go
  • Added the pr-type/bug-fix label

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@klesh klesh added the pr-type/bug-fix This PR fixes a bug label May 16, 2026
@dosubot dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. component/config-ui This issue or PR relates to config-ui component/plugins This issue or PR relates to plugins labels May 16, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@Startrekzky Startrekzky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Startrekzky Startrekzky merged commit f03b83d into main May 17, 2026
11 checks passed
@Startrekzky Startrekzky deleted the kw-fix-dbt branch May 17, 2026 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/config-ui This issue or PR relates to config-ui component/plugins This issue or PR relates to plugins pr-type/bug-fix This PR fixes a bug size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants