Skip to content

Conversation

@PsiACE
Copy link
Member

@PsiACE PsiACE commented Dec 31, 2025

  • Add rustdoc examples across countmin/frequencies/hll/theta/tdigest
  • Add minimal examples for public Error and ResizeFactor types to improve doc interactivity.

Close #55

PsiACE added 2 commits January 1, 2026 03:27
Signed-off-by: Chojan Shang <psiace@apache.org>
Signed-off-by: Chojan Shang <psiace@apache.org>
@leerho
Copy link
Member

leerho commented Jan 1, 2026

I need to see an approving review by a Rust contributor before I feel comfortable in merging this :)

Copy link
Contributor

@notfilippo notfilippo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a couple of nits.

Signed-off-by: Chojan Shang <psiace@apache.org>
@PsiACE
Copy link
Member Author

PsiACE commented Jan 2, 2026

All comments have been addressed. Thanks to @ZENOTME and @notfilippo for your reviews.

@notfilippo
Copy link
Contributor

@leerho / @freakyzoidberg feel free to merge :)

@leerho leerho merged commit 9ade42d into apache:main Jan 4, 2026
9 checks passed
@PsiACE PsiACE deleted the update-rust-docs branch January 5, 2026 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add rustdoc examples for public API

4 participants