Include null_aware status in the relevant Join node display implementations#22913
Open
AdamGS wants to merge 3 commits into
Open
Include null_aware status in the relevant Join node display implementations#22913AdamGS wants to merge 3 commits into
null_aware status in the relevant Join node display implementations#22913AdamGS wants to merge 3 commits into
Conversation
github-actions
Bot
added
logical-expr
Signed-off-by: Adam Gutglick <adamgsal@gmail.com>
AdamGS
force-pushed
the
adamg/null-aware-hash-join-display
branch
from
0ed8e88 to
ed0b9d1
Compare
2010YOUY01
approved these changes
Jun 12, 2026
2010YOUY01
left a comment
2010YOUY01
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thank you! Left one minor suggestion for extra test.
| writeln!(f, "NullsEqual: true")?; | ||
| } | ||
|
|
||
| if self.null_aware { |
Contributor
There was a problem hiding this comment.
Let's add test for this
-- in slt
explain format tree
select...
Contributor
Author
There was a problem hiding this comment.
done, put it in explain_tree.slt.
Signed-off-by: Adam Gutglick <adamgsal@gmail.com>
|
Thank you for opening this pull request! Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). Details |
Contributor
Author
|
semver check failure is a false positive, see #22933 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
This change makes testing null_aware behavior easier, and also makes the performance of various joins clearer - null_aware joins do extra work.
This was originally part #21585, but it seems like there is a bunch of activity around null-aware joins, so I figured its worth splitting out.
What changes are included in this PR?
Add a
null_awareindication to relevant Display implementations when appropriate.Are these changes tested?
SLT tests
Are there any user-facing changes?
Display only