perf: Optimize lcd, gcd NULL handling#21468
Open
neilconway wants to merge 2 commits intoapache:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
lcm,gcd#21467.Rationale for this change
This PR implements three distinct optimizations:
lcmwas computing the result NULL buffer iteratively. This is relatively slow. Switching to Arrow'stry_binarykernel makes the implementation more concise and also improves performance by computing the result NULL buffer via the bitwise union of the input NULL buffers.gcdscalar arg path was doing similarly; switching to Arrow'stry_unaryyields a similar speedup.gcdscalar path, computing the GCD can only fail in a few edge cases (e.g.,gcd(i64::MIN, i64::MIN)). It is cheap to check for these edge-cases; for mostgcdinputs, we can use Arrow'sunarykernel instead oftry_unary. The former is more efficient because it allows LLVM to vectorize the code more effectively.Benchmarks (ARM64):
What changes are included in this PR?
lcdlcdto SLTlcdandgcmNULL handlinggcmto avoid overhead for edge casesAre these changes tested?
Yes. Benchmark results above. I inspected the generated code for the
gcdcase to confirm that LLVM is able to generate better code for theunarycase than for thetry_unarycase.Are there any user-facing changes?
No.