[datafusion-functions-aggregate]: add ordered first_last tests#21461
Draft
alamb wants to merge 1 commit intoapache:mainfrom
Draft
[datafusion-functions-aggregate]: add ordered first_last tests#21461alamb wants to merge 1 commit intoapache:mainfrom
alamb wants to merge 1 commit intoapache:mainfrom
Conversation
alamb
commented
Apr 8, 2026
| Ok(()) | ||
| } | ||
|
|
||
| #[test] |
Contributor
Author
There was a problem hiding this comment.
Specifically this adds coverage to:
FirstValueAccumulator::update_batch: https://github.com/apache/datafusion/blob/main/datafusion/functions-aggregate/src/first_last.rs#L925FirstValueAccumulator::merge_batchafter validation: https://github.com/apache/datafusion/blob/main/datafusion/functions-aggregate/src/first_last.rs#L943LastValueAccumulator::update_batch: https://github.com/apache/datafusion/blob/main/datafusion/functions-aggregate/src/first_last.rs#L1313LastValueAccumulator::merge_batchafter validation: https://github.com/apache/datafusion/blob/main/datafusion/functions-aggregate/src/first_last.rs#L1333
Contributor
Author
|
I would actually like this to be slt tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
GroupsAccumulatorforfirst_valueaggregate (speed upfirst_valueandDISTINCT ONqueries) #17899Rationale for this change
While reviewing #21383 I found some uncovered paths that I wanted to add tests for
What changes are included in this PR?
Add some more
first_lasttests for accumulatorAre these changes tested?
Yes
Are there any user-facing changes?
No, only tests