minor: use IgnoreCometNativeScan for StringPredicate test in 3.4.3 diff#3830
Open
minor: use IgnoreCometNativeScan for StringPredicate test in 3.4.3 diff#3830
IgnoreCometNativeScan for StringPredicate test in 3.4.3 diff#3830Conversation
Change the tag on "filter pushdown - StringPredicate" test from IgnoreCometNativeDataFusion to IgnoreCometNativeScan for consistency with the 3.5.8 and 4.0.1 diffs.
andygrove
changed the title
IgnoreCometNativeScan for StringPredicate test in 3.4.3 diff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A - minor diff consistency fix.
Rationale for this change
The
filter pushdown - StringPredicatetest in the 3.4.3 Spark SQL test diff usesIgnoreCometNativeDataFusionwhile the same test in the 3.5.8 and 4.0.1 diffs usesIgnoreCometNativeScan. The test fails because the native scan doesn't propagate theNumRowGroupsAccSpark accumulator, soIgnoreCometNativeScanis the more appropriate tag.What changes are included in this PR?
Changed the tag on the "filter pushdown - StringPredicate" test in
dev/diffs/3.4.3.difffromIgnoreCometNativeDataFusiontoIgnoreCometNativeScanfor consistency with the other Spark version diffs.How are these changes tested?
Verified the test still fails with
COMET_PARQUET_SCAN_IMPL=native_datafusion(accumulator returns 0), confirming the ignore tag is still needed. The change only narrows the scope of the ignore to match the other diffs.