Skip to content

test: cast negative zero to string#3829

Open
kazuyukitanimura wants to merge 1 commit intoapache:mainfrom
kazuyukitanimura:fix-1036
Open

test: cast negative zero to string#3829
kazuyukitanimura wants to merge 1 commit intoapache:mainfrom
kazuyukitanimura:fix-1036

Conversation

@kazuyukitanimura
Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Closes #1036
Related #3811

Rationale for this change

What changes are included in this PR?

How are these changes tested?

Copy link
Copy Markdown
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kazuyukitanimura Could you confirm the tests actually catch the negative zero case? The Rust format! macro still formats -0.0 as "-0.0" and I don't see a code change that normalizes it. It would be helpful to see the test output or add a more targeted assertion, for example a SQL file test like:

SELECT CAST(CAST('-0.0' AS FLOAT) AS STRING)

This would make it clear that Comet returns "0.0" rather than "-0.0". I tried this yesterday and saw an incompatibility that I wasn't able to fix easily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cast negative zero to string inconsistent with Spark

2 participants