test: cast negative zero to string#3829
Open
kazuyukitanimura wants to merge 1 commit intoapache:mainfrom
Open
Conversation
andygrove
requested changes
Mar 28, 2026
Member
andygrove
left a comment
There was a problem hiding this comment.
@kazuyukitanimura Could you confirm the tests actually catch the negative zero case? The Rust format! macro still formats -0.0 as "-0.0" and I don't see a code change that normalizes it. It would be helpful to see the test output or add a more targeted assertion, for example a SQL file test like:
SELECT CAST(CAST('-0.0' AS FLOAT) AS STRING)This would make it clear that Comet returns "0.0" rather than "-0.0". I tried this yesterday and saw an incompatibility that I wasn't able to fix easily.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1036
Related #3811
Rationale for this change
What changes are included in this PR?
How are these changes tested?