feat: Add support for Spark Pi math expression#3789
Open
rafafrdz wants to merge 2 commits intoapache:mainfrom
Open
feat: Add support for Spark Pi math expression#3789rafafrdz wants to merge 2 commits intoapache:mainfrom
rafafrdz wants to merge 2 commits intoapache:mainfrom
Conversation
Add Pi constant function by delegating to DataFusion's built-in pi() implementation via CometScalarFunction. Includes SQL test verifying the constant value.
andygrove
reviewed
Mar 25, 2026
| statement | ||
| INSERT INTO test_pi VALUES (1.0) | ||
|
|
||
| query tolerance=1e-15 |
Member
There was a problem hiding this comment.
Tests with tolerance are not confirming that the queries actually ran in Comet due to a bug that I just discovered. Let's merge #3797 first
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Piconstant expressionpi()function viaCometScalarFunctionTest plan
pi.sqlCometSqlFileTestSuiteverified — all 2 tests pass (dictionary=false/true)Related to #2084