Skip to content

Conversation

@andygrove
Copy link
Member

@andygrove andygrove commented Dec 24, 2025

Which issue does this PR close?

Closes #2955

I will mark as ready for review after #2964, #2979, and #2980 are merged.

Rationale for this change

Add remaining benchmarks to cover all expressions. I can split these out into smaller PRs after the holidays if needed ... or we could just merge as is and then follow up with smaller PRs for any improvements that anyone wants. This PR gives us instant coverage of all expressions, which is helpful in prioritizing optimization efforts.

What changes are included in this PR?

How are these changes tested?

@codecov-commenter
Copy link

codecov-commenter commented Dec 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.58%. Comparing base (f09f8af) to head (ed22bbb).
⚠️ Report is 801 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2984      +/-   ##
============================================
+ Coverage     56.12%   59.58%   +3.46%     
- Complexity      976     1377     +401     
============================================
  Files           119      167      +48     
  Lines         11743    15493    +3750     
  Branches       2251     2569     +318     
============================================
+ Hits           6591     9232    +2641     
- Misses         4012     4962     +950     
- Partials       1140     1299     +159     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andygrove andygrove changed the title chore: Add microbenchmarks for all expressions [WIP] chore: Add microbenchmarks for all expressions Dec 24, 2025
@andygrove andygrove marked this pull request as ready for review December 24, 2025 20:25
@andygrove andygrove marked this pull request as draft December 24, 2025 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Standardize microbenchmarks

2 participants