Skip to content

Set max-parallel for all GitHub action jobs #1602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stevedlawrence merged 1 commit into from
Mar 3, 2026
Merged

Set max-parallel for all GitHub action jobs #1602

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ jobs:
code-format:
name: TypeScript/Scala/Svelte Formatting
strategy:
max-parallel: 1
matrix:
java_distribution: [temurin]
java_version: [17]
Expand Down Expand Up @@ -107,6 +108,7 @@ jobs:
build-test-package:
name: "Build, Test, and Package (OS: ${{ matrix.os }}, Node: ${{ matrix.node }}, Java: ${{ matrix.java_version }}, VS Code: ${{ matrix.vscode }})"
strategy:
max-parallel: 15
Copy link
Copy Markdown
Member Author

@stevedlawrence stevedlawrence Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the matrix for this job results in 44 jobs. With a max-parallel of 15, this is expected to take approximately 3 times longer. Maybe that's fine if each job is only a couple of minutes. But it might be worth taking a look at this matrix to see if all of these jobs are really necessary, or if some could be removed and still provide confidence that a PR does not break anything.

Copy link
Copy Markdown
Contributor

@shanedell shanedell Feb 4, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevedlawrence Do you think possibly removing ubuntu or macos from some would be okay? Basically doing the assumption that if it works on Ubuntu or MacOS it should work on the other or what would you suggest?

Copy link
Copy Markdown
Member Author

@stevedlawrence stevedlawrence Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, daffodil only has one job for macOS so cutting back some of the OS matrices seems reasonable to me. Especially since typescript and Java are mostly OS agnostic.

The main issue we frequently run into with OS differences is related to paths (e.g. slashes, spaces, newlines). And those are usually Java/typescript version agnostic. So also long as you have at least one job for each OS, one job for each Java version, typescript version, etc. you probably can get away with having a fairly sparse matrix.

Copy link
Copy Markdown
Contributor

@shanedell shanedell Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think that should be done in a different PR or in this one?

Copy link
Copy Markdown
Member Author

@stevedlawrence stevedlawrence Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a preference whether it's part of this PR or separate. I'll leave it up the the daffodil-vscode devs.

If you'd like to include the changes in this PR, feel free to push what you decide to exclude to this PR branch.

matrix:
java_distribution: [temurin]
java_version: [8, 11, 17, 21]
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/licenses.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ jobs:
rat-check:
name: Rat Check
strategy:
max-parallel: 1
matrix:
java_distribution: [temurin]
java_version: [17]
Expand Down Expand Up @@ -63,6 +64,7 @@ jobs:
node-missing-license-data-check:
name: Node Missing LICENSE Data Check
strategy:
max-parallel: 1
matrix:
os: [ubuntu-22.04]
node: ["22.14.0"]
Expand Down Expand Up @@ -100,6 +102,7 @@ jobs:
node-license-compatibility:
name: Node LICENSE Compatibility Check
strategy:
max-parallel: 1
matrix:
os: [ubuntu-22.04]
node: ["22.14.0"]
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ jobs:
build-test-package:
name: "Build, Test, and Package (OS: ${{ matrix.os }}, Node: ${{ matrix.node }}, Java: ${{ matrix.java_version }}, VS Code: ${{ matrix.vscode }})"
strategy:
max-parallel: 15
matrix:
os:
[
Expand Down
Loading