-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[CXF-9229] Add PQC TLS 1.3 support via X25519MLKEM768 hybrid KEM #3299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ffang
wants to merge
2
commits into
apache:main
Choose a base branch
from
ffang:CXF-9228
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
79 changes: 79 additions & 0 deletions
79
...tp-jetty/src/main/java/org/apache/cxf/transport/http_jetty/BCJsseServerALPNProcessor.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.apache.cxf.transport.http_jetty; | ||
|
|
||
| import javax.net.ssl.SSLEngine; | ||
|
|
||
| import org.eclipse.jetty.alpn.server.ALPNServerConnection; | ||
| import org.eclipse.jetty.io.Connection; | ||
| import org.eclipse.jetty.io.ssl.ALPNProcessor; | ||
| import org.eclipse.jetty.io.ssl.SslConnection; | ||
| import org.eclipse.jetty.io.ssl.SslHandshakeListener; | ||
|
|
||
| /** | ||
| * Jetty {@link ALPNProcessor.Server} for BouncyCastle JSSE ({@code bctls-jdk18on}). | ||
| * | ||
| * <p>Jetty's built-in {@code JDK9ServerALPNProcessor} only matches engines whose | ||
| * module is {@code java.base}, so it rejects BC JSSE's {@code ProvSSLEngine} and | ||
| * throws {@code IllegalStateException: No suitable ALPNProcessor}. This processor | ||
| * bridges the gap: it claims BC JSSE engines and wires up the same | ||
| * {@link SSLEngine#setHandshakeApplicationProtocolSelector} callback that the | ||
| * built-in processor uses, delegating to {@link ALPNServerConnection#select}. | ||
| * | ||
| * <p>A {@link SslHandshakeListener} is also registered so that if the client does not | ||
| * advertise any ALPN protocols, {@link ALPNServerConnection#unsupported()} is called | ||
| * on handshake success to fall back to the server's default protocol (HTTP/1.1). | ||
| * | ||
| * <p>Registered via {@code META-INF/services/org.eclipse.jetty.io.ssl.ALPNProcessor$Server}. | ||
| */ | ||
| public class BCJsseServerALPNProcessor implements ALPNProcessor.Server { | ||
|
|
||
| @Override | ||
| public boolean appliesTo(SSLEngine sslEngine) { | ||
| return sslEngine.getClass().getName().startsWith("org.bouncycastle."); | ||
| } | ||
|
|
||
| @Override | ||
| public void configure(SSLEngine sslEngine, Connection connection) { | ||
| ALPNServerConnection alpnConn = (ALPNServerConnection) connection; | ||
|
|
||
| // Called when the client includes an ALPN extension in its ClientHello. | ||
| sslEngine.setHandshakeApplicationProtocolSelector((engine, protocols) -> { | ||
| try { | ||
| alpnConn.select(protocols); | ||
| return alpnConn.getProtocol(); | ||
| } catch (Throwable t) { | ||
| return null; | ||
| } | ||
| }); | ||
|
|
||
| // When the client sends no ALPN extension the selector above is never invoked, | ||
| // leaving getProtocol() null. The SslHandshakeListener fires on handshake | ||
| // completion and calls unsupported() to fall back to the default protocol. | ||
| SslConnection.SslEndPoint sslEndPoint = (SslConnection.SslEndPoint) alpnConn.getEndPoint(); | ||
| sslEndPoint.getSslConnection().addHandshakeListener(new SslHandshakeListener() { | ||
| @Override | ||
| public void handshakeSucceeded(Event event) { | ||
| if (alpnConn.getProtocol() == null) { | ||
| alpnConn.unsupported(); | ||
| } | ||
| } | ||
| }); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
...-jetty/src/main/resources/META-INF/services/org.eclipse.jetty.io.ssl.ALPNProcessor$Server
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| org.apache.cxf.transport.http_jetty.BCJsseServerALPNProcessor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if we should consider multi-release jar and have clean JDK-20+ implementation?