Conversation
jiahuili430
force-pushed
the
improve-replication
branch
from
36127dd to
5ad169b
Compare
| % Worker children get a default 5 second shutdown timeout, so pick a value just | ||
| % a bit less than that: 4.5 seconds. In couch_replicator_sup our scheduler | ||
| % worker doesn't specify the timeout, so it up picks ups the OTP default of 5 | ||
| % worker doesn't specify the timeout, so it picks ups the OTP default of 5 |
jiahuili430
changed the title
since_seq parameter
|
|
||
| StartSeq1 = get_value(since_seq, Options, StartSeq0), | ||
| StartSeq = {0, StartSeq1}, | ||
| StartSeq2 = |
There was a problem hiding this comment.
We can't in general compare sequences. But we can compare with 0 if we're starting from scratch. We should use == 0.
Based on the discussion in #5867 we'd want something like this:
If there is a checkpoint (StartSeq0 =/= 0) use the checkpoint and ignore since_seq. Otherwise (no checkpoint) and user specified a since_seq, use the since_seq
In addition make sure the since_seq is folded into the replication ID (append to the list if it's there but if it isn't make sure to generate the same replication ID as before). This will rewind changes for a existing replications with since_seq back to 0. So it's something to warn the users about in the release notes.
| % exception which would indicate this document is malformed. This exception | ||
| % should propagate to db_change function and will be recorded as permanent | ||
| % failure in the document. User will have to update the documet to fix the | ||
| % failure in the document. User will have to update the document to fix the |
There was a problem hiding this comment.
please make the many (and welcome!) documentation fixes in a separate PR to the one making the since_seq enhancement.
4 participants
Overview
Testing recommendations
Related Issues or Pull Requests
Checklist
rel/overlay/etc/default.inisrc/docsfolder