-
Notifications
You must be signed in to change notification settings - Fork 1.1k
chore(docs): Update Performance documentation to include SDio Flag #5870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Shubhang
wants to merge
6
commits into
apache:main
Choose a base branch
from
Shubhang:docs-update-Sdio
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+8
−0
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
fd87e1e
Update performance.rst
ss186222 7964897
Revert "Update performance.rst"
Shubhang d5a6c1e
Update performance.rst
Shubhang 2e88457
Update performance.rst
Shubhang 55310fa
Update performance.rst
Shubhang 370523a
Update performance.rst
Shubhang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note, the flag is
+SDio ...(capitalD) (double-check at https://www.erlang.org/doc/apps/erts/erl_cmd.html#emulator-flags)I wonder since the
+Aadvice doesn't apply any longer maybe we should mention the correct way of updating the value and to usevm.argshttps://github.com/apache/couchdb/blob/main/rel/overlay/etc/vm.args#L71-L73. Maybe at the end, as minor note, we could add that this used to be an+Aand that it doesn't apply any longer, and that+Asetting should be removed.(suggestion)
That's just a suggestion, it can probably use better wording