Skip to content
This repository was archived by the owner on May 25, 2021. It is now read-only.

Configurable default limit#30

Merged
asfgit merged 1 commit intoapache:masterfrom
cloudant:75444-mango-configurable-default
Oct 5, 2016
Merged

Configurable default limit#30
asfgit merged 1 commit intoapache:masterfrom
cloudant:75444-mango-configurable-default

Conversation

@rnewson
Copy link
Member

@rnewson rnewson commented Oct 4, 2016

No description provided.

@kxepal
Copy link
Member

kxepal commented Oct 4, 2016

+1
Thought should note that this changes default behaviour for some indexers which can surprise people.

@tonysun83
Copy link
Contributor

This ties in with apache/couchdb-couch-mrview#56. Can we discuss a little more with making limits configurable across the board?

@kxepal
Copy link
Member

kxepal commented Oct 4, 2016

@tonysun83
I see in this PR unification of all the limits, but agree.

@tonysun83
Copy link
Contributor

The question arises: do we want to see json indexes as an extension of views and thus use the same limits or as a separate entity itself and thus a separate configurable value? I'll update the other PR as well regarding configuring view limits once I collect my thoughts.

@kxepal
Copy link
Member

kxepal commented Oct 4, 2016

@tonysun83 Good point. I think, from user side, it would be hard to explain why views and mango indexes should act differently.

@tonysun83
Copy link
Contributor

+1, let's merge this and then open a PR later to match mango and views

@davisp
Copy link
Member

davisp commented Oct 5, 2016

+1

@asfgit asfgit merged commit ddd6a4d into apache:master Oct 5, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments