Fix case-insensitive Strings.replace dropping length-changing matches#1697
Merged
Merged
Conversation
Member
|
Thank you @alhudz , merged 🚀 |
garydgregory
added a commit
that referenced
this pull request
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repro:
Strings.CI.replace("aİb", "İ", "X", -1)returnsaİbinstead ofaXbunder any non-Turkish locale (StringUtils.replaceIgnoreCase/replaceOnceIgnoreCasedelegate here, so they are affected too).Cause:
replacelower-cases the search argument up front, but the case-insensitiveindexOfit calls already matches case-insensitively throughCharSequenceUtils.regionMatches.'İ'(U+0130) lower-cases to the two-char"i̇", so both the needle and the derivedreplLengthgrow to length 2 and stop lining up with the single source character, so the match is silently dropped.Fix: remove the redundant lower-casing and let the case-insensitive
indexOfdo the matching. The case-sensitive path never lower-cased, so it is unchanged.The regression test pins the locale with
@DefaultLocale("en")so the lower-case expansion is deterministic; it fails on the current code and passes with the fix.mvn; that'smvnon the command line by itself.