LANG-1725: Throw IllegalArgumentException instead of IndexOutOfBounds… #1547
+3
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses LANG-1725 by updating the
Conversionclass to throwIllegalArgumentExceptioninstead ofIndexOutOfBoundsExceptionwhen a provided index is out of bounds.Changes
binaryBeMsb0ToHexDigit(boolean[], int)to throwIllegalArgumentException. The originalIndexOutOfBoundsExceptionis now wrapped as the cause to preserve the technical stack trace.binaryBeMsb0ToHexDigitPosOutsideArrayto expectIllegalArgumentException.Quality Check
mvn test -Dtest=ConversionTestand achieved BUILD SUCCESS.