Skip to content

Conversation

@IcoreE
Copy link
Contributor

@IcoreE IcoreE commented Dec 23, 2025

The MethodFixtures class contains a method with a typo in its name (geStringtVarStringArgs) and a corresponding static helper method that references this misspelled name, which impacts code readability and maintainability: 

  1. Misspelled method name
// Incorrect: "geStringt" (extra 't' after 'String')
public String geStringtVarStringArgs(final String... strings) {
    return "XYZ";
}
  1. Dependent static helper method
    The static method getMethodForGetStringVarStringArgs() references the misspelled method name via reflection:
static Method getMethodForGetStringVarStringArgs() throws NoSuchMethodException, SecurityException {
    // References the typo'd method name "geStringtVarStringArgs"
    return getDeclaredMethod("geStringtVarStringArgs", String[].class);
}  

@garydgregory
Copy link
Member

@IcoreE
Please refrain from creating Jira tickets for minor changes.

@IcoreE
Copy link
Contributor Author

IcoreE commented Dec 23, 2025

Okay, I'll be more careful with this from now on. Thanks for reminding me. @garydgregory

@garydgregory garydgregory merged commit 8dbe33e into apache:master Dec 23, 2025
34 of 36 checks passed
@garydgregory
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants