Skip to content

Conversation

@vishesh92
Copy link
Member

@vishesh92 vishesh92 commented Aug 13, 2024

Description

This PR adds the feature to show applied search filters in the UI.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Screenshots (if appropriate):

image

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@vishesh92
Copy link
Member Author

@blueorangutan ui

@blueorangutan
Copy link

@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@codecov
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 16.26%. Comparing base (35e6d7c) to head (7425811).
⚠️ Report is 8 commits behind head on 4.20.

Additional details and impacted files
@@             Coverage Diff              @@
##               4.20    #9520      +/-   ##
============================================
- Coverage     16.26%   16.26%   -0.01%     
  Complexity    13418    13418              
============================================
  Files          5658     5660       +2     
  Lines        499494   499863     +369     
  Branches      60625    60690      +65     
============================================
+ Hits          81232    81284      +52     
- Misses       409214   409509     +295     
- Partials       9048     9070      +22     
Flag Coverage Δ
uitests 4.15% <ø> (+0.12%) ⬆️
unittests 17.11% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9520 (QA-JID-419)

@vishesh92 vishesh92 force-pushed the ui-show-search-filters branch 2 times, most recently from 47e4a82 to 00985d0 Compare August 13, 2024 12:10
@vishesh92
Copy link
Member Author

@blueorangutan ui

@blueorangutan
Copy link

@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9520 (QA-JID-420)

@vishesh92 vishesh92 force-pushed the ui-show-search-filters branch from 00985d0 to 21ca320 Compare August 16, 2024 07:49
@vishesh92
Copy link
Member Author

@blueorangutan ui

@blueorangutan
Copy link

@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9520 (QA-JID-421)

@sureshanaparti
Copy link
Contributor

sureshanaparti commented Aug 16, 2024

Search message not in sync with filters =>

diff-msg-shown

UUIDs loaded instead of name for Zone, Group in filter view (on close & re-open) - Check if selected names can be populated as before =>

uuid-loaded-on-filter-view uuid-loaded-on-filter-view-zone-and-group

@vishesh92 vishesh92 force-pushed the ui-show-search-filters branch from 267d78b to 1655b61 Compare August 16, 2024 10:23
@vishesh92 vishesh92 force-pushed the ui-show-search-filters branch 3 times, most recently from a2a3260 to b0ea771 Compare August 27, 2024 08:42
@vishesh92
Copy link
Member Author

@blueorangutan ui

@apache apache deleted a comment from blueorangutan Aug 27, 2024
@blueorangutan
Copy link

@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9520 (QA-JID-434)

@apache apache deleted a comment from blueorangutan Aug 28, 2024
@apache apache deleted a comment from blueorangutan Aug 28, 2024
@apache apache deleted a comment from blueorangutan Aug 28, 2024
@apache apache deleted a comment from blueorangutan Aug 28, 2024
@apache apache deleted a comment from blueorangutan Aug 28, 2024
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm tested in qa

@vishesh92 vishesh92 changed the base branch from 4.22 to 4.20 January 28, 2026 13:02
@vishesh92 vishesh92 force-pushed the ui-show-search-filters branch 3 times, most recently from 533ab77 to 6b51f58 Compare January 28, 2026 13:17
@vishesh92 vishesh92 force-pushed the ui-show-search-filters branch from 6b51f58 to 07bd2de Compare January 28, 2026 13:19
@vishesh92
Copy link
Member Author

@blueorangutan ui

@blueorangutan
Copy link

@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9520 (QA-JID-857)

@borisstoyanov
Copy link
Contributor

Screenshot 2026-01-28 at 3 46 41 pm LGTM

@borisstoyanov borisstoyanov marked this pull request as ready for review January 28, 2026 13:47
Copilot AI review requested due to automatic review settings January 28, 2026 13:47
@DaanHoogland
Copy link
Contributor

@vishesh92 , can you look at the ui build (test) issues?

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds UI support to display currently applied search filters (from route query params) as removable “chips” beneath the search bar.

Changes:

  • Render a new SearchFilter row in AutogenView when enabled by config.
  • Introduce SearchFilter.vue to format query params into human-readable tags and allow removing them.
  • Add a showSearchFilters flag to ui/public/config.json.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 10 comments.

File Description
ui/src/views/AutogenView.vue Adds a conditional row to show applied search filters and handles removing them by updating route query params.
ui/src/components/view/SearchFilter.vue New component that renders filter tags, resolves display labels/values (including via API calls), and emits removals.
ui/public/config.json Adds a config flag to toggle the feature.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@vishesh92
Copy link
Member Author

@blueorangutan ui

@blueorangutan
Copy link

@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9520 (QA-JID-860)

@sureshanaparti
Copy link
Contributor

@blueorangutan ui

@blueorangutan
Copy link

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9520 (QA-JID-861)

@sureshanaparti sureshanaparti self-assigned this Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants