-
Notifications
You must be signed in to change notification settings - Fork 1.3k
UI: Show applied search filters #9520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 4.20
Are you sure you want to change the base?
Conversation
|
@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.20 #9520 +/- ##
============================================
- Coverage 16.26% 16.26% -0.01%
Complexity 13418 13418
============================================
Files 5658 5660 +2
Lines 499494 499863 +369
Branches 60625 60690 +65
============================================
+ Hits 81232 81284 +52
- Misses 409214 409509 +295
- Partials 9048 9070 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
UI build: ✔️ |
47e4a82 to
00985d0
Compare
|
@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
00985d0 to
21ca320
Compare
|
@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
267d78b to
1655b61
Compare
a2a3260 to
b0ea771
Compare
|
@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
DaanHoogland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm tested in qa
533ab77 to
6b51f58
Compare
6b51f58 to
07bd2de
Compare
|
@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
@vishesh92 , can you look at the ui build (test) issues? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Adds UI support to display currently applied search filters (from route query params) as removable “chips” beneath the search bar.
Changes:
- Render a new
SearchFilterrow inAutogenViewwhen enabled by config. - Introduce
SearchFilter.vueto format query params into human-readable tags and allow removing them. - Add a
showSearchFiltersflag toui/public/config.json.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 10 comments.
| File | Description |
|---|---|
| ui/src/views/AutogenView.vue | Adds a conditional row to show applied search filters and handles removing them by updating route query params. |
| ui/src/components/view/SearchFilter.vue | New component that renders filter tags, resolves display labels/values (including via API calls), and emits removals. |
| ui/public/config.json | Adds a config flag to toggle the feature. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |




Description
This PR adds the feature to show applied search filters in the UI.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?