Skip to content

Conversation

@JeevanYewale
Copy link
Contributor

Backport of #12480 to 4.20 branch

Fixes #12466

Problem

The keyword parameter in the listBackupOfferings API was not filtering results.

Solution

Changed SearchBuilder operation from EQ to LIKE for the name field in BackupManagerImpl.java

Testing

Already tested and approved in #12480 by @harikrishna-patnala

Related

Signed-off-by: Jeevan Yewale <jeevanyewale4@gmial.com>
Copy link
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Jan 28, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 16.25%. Comparing base (35e6d7c) to head (7ab8e85).
⚠️ Report is 2 commits behind head on 4.20.

Files with missing lines Patch % Lines
...rg/apache/cloudstack/backup/BackupManagerImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               4.20   #12540      +/-   ##
============================================
- Coverage     16.26%   16.25%   -0.01%     
+ Complexity    13418    13416       -2     
============================================
  Files          5658     5658              
  Lines        499494   499494              
  Branches      60625    60625              
============================================
- Hits          81232    81211      -21     
- Misses       409214   409235      +21     
  Partials       9048     9048              
Flag Coverage Δ
uitests 4.02% <ø> (ø)
unittests 17.11% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@nvazquez nvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sureshanaparti
Copy link
Contributor

Fix verified in #12480.

@DaanHoogland DaanHoogland merged commit 1300fc5 into apache:4.20 Jan 28, 2026
24 of 25 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 28, 2026

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants