Fix KvmSshToAgentEnabled setting description and make it dynamic

[nvazquez]

Description

This PR makes the setting kvm.ssh.to.agent dynamic, and updates its description as pointed out on the issue #12529.

The setting has been introduced with the wrong description on the PR: #3239

Fixes: #12529

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 3.57%. Comparing base (5aced73) to head (ba979fa).

❗ There is a different number of reports uploaded between BASE (5aced73) and HEAD (ba979fa). Click for more details.

HEAD has 1 upload less than BASE

Flag	BASE (5aced73)	HEAD (ba979fa)
unittests	1	0

Additional details and impacted files

@@              Coverage Diff              @@
##               main   #12533       +/-   ##
=============================================
- Coverage     17.85%    3.57%   -14.28%     
=============================================
  Files          5930      448     -5482     
  Lines        531409    37908   -493501     
  Branches      64963     7008    -57955     
=============================================
- Hits          94869     1357    -93512     
+ Misses       425914    36385   -389529     
+ Partials      10626      166    -10460     

Flag	Coverage Δ
uitests	3.57% <ø> (ø)
unittests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[nvazquez]

@blueorangutan package

[blueorangutan]

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 16570

[shwstppr]

@nvazquez should we target this for 4.22.1 or 4.20.3 as the config is present there?

[DaanHoogland]

@nvazquez , i would like this in 20.3

[nvazquez]

@shwstppr @DaanHoogland I can target it for 4.20.3, please note the schema changes must be ported to the corresponding schema changes on forward merge to not lose the configuration update on CloudStack upgrades

[github-actions]

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

[nvazquez]

@shwstppr @DaanHoogland updated for 4.20

@blueorangutan package

[blueorangutan]

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[shwstppr]

code lgtm

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16590

[nvazquez]

@blueorangutan test

[blueorangutan]

@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[DaanHoogland]

22.0->22.1, yes

[sureshanaparti]

clgtm

[blueorangutan]

[SF] Trillian test result (tid-15321)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 52007 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12533-t15321-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[sudo87]

lgtm, tested it.

Before upgrade:

After upgrade: