Linstor: support live migration from other primary storage #12532

rp- · 2026-01-27T17:17:23Z

Description

This PR allows live migration from any primary storage to Linstor primary storage.

Fixes: #8032
Fixes: #11826

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Live migration from NFS primary storage and also from another Linstor primary storage.

How did you try to break this feature and the system with this change?

Running Linstor integration tests

codecov · 2026-01-27T17:29:14Z

Codecov Report

❌ Patch coverage is 3.65535% with 369 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.24%. Comparing base (c0b5358) to head (95cf17d).
⚠️ Report is 13 commits behind head on 4.20.

Files with missing lines	Patch %	Lines
...tack/storage/motion/LinstorDataMotionStrategy.java	0.00%	208 Missing ⚠️
...cloudstack/storage/datastore/util/LinstorUtil.java	8.97%	141 Missing and 1 partial ⚠️
...tore/driver/LinstorPrimaryDataStoreDriverImpl.java	0.00%	19 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##               4.20   #12532    +/-   ##
==========================================
  Coverage     16.24%   16.24%            
- Complexity    13396    13406    +10     
==========================================
  Files          5658     5659     +1     
  Lines        499273   499542   +269     
  Branches      60600    60627    +27     
==========================================
+ Hits          81125    81169    +44     
- Misses       409104   409328   +224     
- Partials       9044     9045     +1

Flag	Coverage Δ
uitests	`4.03% <ø> (ø)`
unittests	`17.10% <3.65%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Move reusable methods from LinstorPrimaryDataStoreDriverImpl to LinstorUtil to enable sharing with other components: - logLinstorAnswer, logLinstorAnswers, checkLinstorAnswersThrow - getRscGrp, getEncryptedLayerList, applyQoSSettings - createResourceBase, createResource, spawnResource - canShareTemplateForResourceGroup, foundShareableTemplate Add LIN_PROP_DRBDOPT_EXACT_SIZE constant and exactSize parameter support for DRBD exact-size property handling during resource creation.

DaanHoogland

clgtm

DaanHoogland · 2026-01-28T09:20:29Z

@blueorangutan package

blueorangutan · 2026-01-28T09:22:03Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Copilot

Pull request overview

This PR enables live migration of VMs from any primary storage to Linstor primary storage, addressing issues #8032 and #11826 where migrations from NFS to Linstor were creating qcow files instead of DRBD resources.

Changes:

Added LinstorDataMotionStrategy to handle live migrations to Linstor storage
Refactored common Linstor operations into LinstorUtil for better code reuse
Implemented support for DRBD exact-size property during migration to maintain volume size consistency

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
`LinstorDataMotionStrategy.java`	New data motion strategy that handles live migration from any primary storage to Linstor by creating destination resources and using QEMU to copy data
`LinstorUtil.java`	Added utility methods for resource creation, QoS settings, and encrypted layer handling; moved common code from driver implementation for reuse
`LinstorPrimaryDataStoreDriverImpl.java`	Refactored to use utility methods from LinstorUtil, reducing code duplication
`LinstorPrimaryDataStoreDriverImplTest.java`	Updated test to call utility method instead of driver method
`spring-storage-volume-linstor-context.xml`	Registered LinstorDataMotionStrategy as a Spring bean
`CHANGELOG.md`	Documented the new live migration support feature

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-28T09:28:51Z

...me/linstor/src/main/java/org/apache/cloudstack/storage/motion/LinstorDataMotionStrategy.java

+            }
+        } catch (AgentUnavailableException | OperationTimedoutException | CloudRuntimeException ex) {
+            errMsg = String.format(
+                    "Copy volume(s) of VM [%s] to storage(s) [%s] and VM to host [%s] failed in StorPoolDataMotionStrategy.copyAsync. Error message: [%s].",


The error message incorrectly references "StorPoolDataMotionStrategy" instead of "LinstorDataMotionStrategy". This will be confusing when debugging issues.

Suggested change

"Copy volume(s) of VM [%s] to storage(s) [%s] and VM to host [%s] failed in StorPoolDataMotionStrategy.copyAsync. Error message: [%s].",

"Copy volume(s) of VM [%s] to storage(s) [%s] and VM to host [%s] failed in LinstorDataMotionStrategy.copyAsync. Error message: [%s].",

Copilot · 2026-01-28T09:28:51Z

...e/volume/linstor/src/main/java/org/apache/cloudstack/storage/datastore/util/LinstorUtil.java

+        if (!vlmDfns.isEmpty())
+        {
+            Properties props = vlmDfns.get(0).getProps();
+            long iops = Long.parseLong(props.getOrDefault("sys/fs/blkio_throttle_write_iops", "0"));


Potential uncaught 'java.lang.NumberFormatException'.

Suggested change

long iops = Long.parseLong(props.getOrDefault("sys/fs/blkio_throttle_write_iops", "0"));

Object iopsObj = props.getOrDefault("sys/fs/blkio_throttle_write_iops", "0");

long iops = 0L;

try

{

iops = Long.parseLong(String.valueOf(iopsObj));

}

catch (NumberFormatException ex)

{

LOGGER.warn("Linstor: Invalid QoS IOPS value '{}' for resource {}, treating as unset",

iopsObj, rscName);

}

Implement DataMotionStrategy for live migration of VMs with volumes on Linstor or other primary storage. Key features: - Support live migration with storage from other primary storages - Preserve DRBD exact-size property during migration

blueorangutan · 2026-01-28T10:24:21Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16585

DaanHoogland · 2026-01-28T12:14:20Z

@blueorangutan package

blueorangutan · 2026-01-28T12:16:05Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-01-28T13:25:24Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16593

DaanHoogland · 2026-01-28T15:29:25Z

@blueorangutan test

blueorangutan · 2026-01-28T15:30:03Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2026-01-29T07:39:33Z

[SF] Trillian test result (tid-15322)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 55052 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12532-t15322-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

rp- added this to the 4.20.3 milestone Jan 27, 2026

rp- self-assigned this Jan 27, 2026

rp- added component:kvm 3rd-party:linstor labels Jan 27, 2026

boring-cyborg bot added component:primary-storage component:storage labels Jan 27, 2026

rp- force-pushed the linstor-4.20-data-motion-linstor-2-linstor branch from 93af47f to 984e3f7 Compare January 27, 2026 17:45

DaanHoogland requested a review from Copilot January 28, 2026 09:18

Copilot started reviewing on behalf of DaanHoogland January 28, 2026 09:19 View session

DaanHoogland approved these changes Jan 28, 2026

View reviewed changes

Copilot AI reviewed Jan 28, 2026

View reviewed changes

rp- force-pushed the linstor-4.20-data-motion-linstor-2-linstor branch from 984e3f7 to 95cf17d Compare January 28, 2026 09:38

JeevanYewale mentioned this pull request Jan 28, 2026

Fix keyword parameter filtering in listBackupOfferings API #12480

Closed

DaanHoogland added the status:needs-review label Jan 29, 2026

	"Copy volume(s) of VM [%s] to storage(s) [%s] and VM to host [%s] failed in StorPoolDataMotionStrategy.copyAsync. Error message: [%s].",
	"Copy volume(s) of VM [%s] to storage(s) [%s] and VM to host [%s] failed in LinstorDataMotionStrategy.copyAsync. Error message: [%s].",

-            long iops = Long.parseLong(props.getOrDefault("sys/fs/blkio_throttle_write_iops", "0"));
+            Object iopsObj = props.getOrDefault("sys/fs/blkio_throttle_write_iops", "0");
+            long iops = 0L;
+            try
+            {
+                iops = Long.parseLong(String.valueOf(iopsObj));
+            }
+            catch (NumberFormatException ex)
+            {
+                LOGGER.warn("Linstor: Invalid QoS IOPS value '{}' for resource {}, treating as unset",
+                        iopsObj, rscName);
+            }

Linstor: support live migration from other primary storage #12532

Are you sure you want to change the base?

Linstor: support live migration from other primary storage #12532

Conversation

rp- commented Jan 27, 2026

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecov bot commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Jan 28, 2026

Uh oh!

blueorangutan commented Jan 28, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Jan 28, 2026

Uh oh!

DaanHoogland commented Jan 28, 2026

Uh oh!

blueorangutan commented Jan 28, 2026

Uh oh!

blueorangutan commented Jan 28, 2026

Uh oh!

DaanHoogland commented Jan 28, 2026

Uh oh!

blueorangutan commented Jan 28, 2026

Uh oh!

blueorangutan commented Jan 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Jan 27, 2026 •

edited

Loading