Skip to content

NPE fix while deleting storage pool when pool has detached volumes #12451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
borisstoyanov merged 8 commits into from
Jan 26, 2026

build fix

6c1c286
Select commit
Loading
Failed to load commit list.
Merged

NPE fix while deleting storage pool when pool has detached volumes #12451

build fix
6c1c286
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 21, 2026 in 1s

16.24% (+0.00%) compared to 8db7cab

View this Pull Request on Codecov

16.24% (+0.00%) compared to 8db7cab

Details

Codecov Report

❌ Patch coverage is 36.00000% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.24%. Comparing base (8db7cab) to head (6c1c286).

Files with missing lines Patch % Lines
...main/java/com/cloud/storage/dao/VolumeDaoImpl.java 0.00% 3 Missing ⚠️
...storage/datastore/provider/DateraHostListener.java 0.00% 2 Missing ⚠️
...rage/datastore/provider/SolidFireHostListener.java 0.00% 2 Missing ⚠️
...dstack/storage/datastore/PrimaryDataStoreImpl.java 0.00% 1 Missing ⚠️
...va/org/apache/cloudstack/sioc/SiocManagerImpl.java 0.00% 1 Missing ⚠️
...datastore/driver/DateraPrimaryDataStoreDriver.java 0.00% 1 Missing ⚠️
...astore/driver/SolidFirePrimaryDataStoreDriver.java 0.00% 1 Missing ⚠️
...tastore/driver/StorPoolPrimaryDataStoreDriver.java 0.00% 1 Missing ⚠️
...src/main/java/com/cloud/server/StatsCollector.java 0.00% 1 Missing ⚠️
...ain/java/com/cloud/storage/StorageManagerImpl.java 87.50% 1 Missing ⚠️
... and 2 more
Additional details and impacted files 
@@            Coverage Diff            @@
##               4.20   #12451   +/-   ##
=========================================
  Coverage     16.24%   16.24%           
- Complexity    13393    13394    +1     
=========================================
  Files          5657     5657           
  Lines        499107   499109    +2     
  Branches      60574    60575    +1     
=========================================
+ Hits          81069    81072    +3     
  Misses       409001   409001           
+ Partials       9037     9036    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov