Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 4.20 #12350 +/- ##
=========================================
Coverage 16.23% 16.23%
Complexity 13378 13378
=========================================
Files 5657 5657
Lines 498866 498866
Branches 60545 60545
=========================================
Hits 81011 81011
Misses 408821 408821
Partials 9034 9034
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR fixes a spelling typo in an enum value throughout the Apache CloudStack codebase, correcting Event.OperationSuccessed to Event.OperationSucceeded to use proper English grammar.
Key Changes
- Renamed the enum value
OperationSuccessedtoOperationSucceededinObjectInDataStoreStateMachine.Event - Updated all references to this enum value across storage-related implementation classes, services, and strategies
- Updated test expectations to use the corrected enum value
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| engine/api/src/main/java/org/apache/cloudstack/engine/subsystem/api/storage/ObjectInDataStoreStateMachine.java | Renamed enum value from OperationSuccessed to OperationSucceeded; also made State._description final and removed redundant private modifier from enum constructor |
| engine/storage/src/main/java/org/apache/cloudstack/storage/datastore/ObjectInDataStoreManagerImpl.java | Updated all state machine transitions to use the corrected enum value; removed some extraneous blank lines |
| engine/storage/src/main/java/org/apache/cloudstack/storage/datastore/DataObjectManagerImpl.java | Updated event references in async callbacks to use corrected enum value |
| engine/storage/volume/src/main/java/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java | Updated numerous event processing calls across various callback methods to use corrected enum value |
| engine/storage/volume/src/main/java/org/apache/cloudstack/storage/volume/VolumeObject.java | Updated event mapping to use corrected enum value |
| engine/storage/volume/src/test/java/org/apache/cloudstack/storage/volume/VolumeObjectTest.java | Updated test expectations to use corrected enum value |
| engine/storage/snapshot/src/main/java/org/apache/cloudstack/storage/snapshot/SnapshotServiceImpl.java | Updated event processing calls in snapshot-related callbacks to use corrected enum value |
| engine/storage/snapshot/src/main/java/org/apache/cloudstack/storage/snapshot/DefaultSnapshotStrategy.java | Updated event processing in snapshot backup to use corrected enum value |
| engine/storage/image/src/main/java/org/apache/cloudstack/storage/image/TemplateServiceImpl.java | Updated event processing calls in template-related callbacks to use corrected enum value |
| engine/storage/image/src/main/java/org/apache/cloudstack/storage/image/SecondaryStorageServiceImpl.java | Updated event processing in data migration callback to use corrected enum value |
| engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java | Updated event processing calls in various data motion strategies to use corrected enum value |
| engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/AncientDataMotionStrategy.java | Updated event processing in volume copying to use corrected enum value |
| engine/storage/cache/src/main/java/org/apache/cloudstack/storage/cache/manager/StorageCacheManagerImpl.java | Updated event processing in cache object creation to use corrected enum value |
| plugins/storage/volume/storpool/src/main/java/org/apache/cloudstack/storage/snapshot/StorPoolSnapshotStrategy.java | Updated event processing in snapshot deletion to use corrected enum value |
| plugins/storage/volume/storpool/src/main/java/org/apache/cloudstack/storage/motion/StorPoolDataMotionStrategy.java | Updated event processing in post-migration handling to use corrected enum value |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...age/image/src/main/java/org/apache/cloudstack/storage/image/SecondaryStorageServiceImpl.java
Show resolved
Hide resolved
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16209 |
|
@blueorangutan test |
|
@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-15084)
|
|
@sureshanaparti @abh1sar @sudo87 , I think these smoke test results are ok and sufficient, do you? |
yes, smoke tests should be sufficient |
abh1sar
added
status:ready-for-merge
and removed
status:waiting-for-smoketest-results
labels
5 participants
Description
This PR fixes typo in the object event (Event.OperationSuccessed => Event.OperationSucceeded)
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?