Skip to content

Improve logs for VM migrations #12332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DaanHoogland merged 2 commits into from
Jan 9, 2026

Apply suggestions from code review

d57e3ac
Select commit
Loading
Failed to load commit list.
Merged

Improve logs for VM migrations #12332

Apply suggestions from code review
d57e3ac
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 8, 2026 in 0s

17.59% (+0.00%) compared to 55ab7c5

View this Pull Request on Codecov

17.59% (+0.00%) compared to 55ab7c5

Details

Codecov Report

❌ Patch coverage is 11.42857% with 31 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.59%. Comparing base (55ab7c5) to head (d57e3ac).
⚠️ Report is 17 commits behind head on 4.22.

Files with missing lines Patch % Lines
...n/java/com/cloud/vm/VirtualMachineManagerImpl.java 0.00% 21 Missing ⚠️
...resource/wrapper/LibvirtMigrateCommandWrapper.java 37.50% 5 Missing ⚠️
...pper/LibvirtPrepareForMigrationCommandWrapper.java 25.00% 3 Missing ⚠️
.../src/main/java/com/cloud/vm/UserVmManagerImpl.java 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##               4.22   #12332    +/-   ##
==========================================
  Coverage     17.59%   17.59%            
- Complexity    15595    15597     +2     
==========================================
  Files          5910     5910            
  Lines        529606   529718   +112     
  Branches      64705    64716    +11     
==========================================
+ Hits          93178    93206    +28     
- Misses       425940   426021    +81     
- Partials      10488    10491     +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov