ui: fix test delivery params in create webhook form#12318
ui: fix test delivery params in create webhook form#12318DaanHoogland merged 1 commit intoapache:4.20from
Conversation
Fixes apache#12317 Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
|
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.20 #12318 +/- ##
=========================================
Coverage 16.23% 16.23%
Complexity 13379 13379
=========================================
Files 5657 5657
Lines 498865 498865
Branches 60545 60545
=========================================
+ Hits 81007 81010 +3
- Misses 408821 408825 +4
+ Partials 9037 9030 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
UI build: ✔️ |
| @@ -135,7 +135,7 @@ | |||
| <test-webhook-delivery-view | |||
| ref="dispatchview" | |||
| :payloadUrl="form.payloadurl" | |||
| :sslVerification="form.sslverification" | |||
| :sslVerification="isPayloadUrlHttps && form.sslverification" | |||
There was a problem hiding this comment.
should this be || instead of &&?
There was a problem hiding this comment.
no @DaanHoogland. SSL option in the form is shown only for HTTPS urls
|
@blueorangutan package |
|
@kiranchavala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16205 |
There was a problem hiding this comment.
LGTM
Before Fix
10.0.33.72 - - [30/Dec/2025 06:49:04] "POST / HTTP/1.1" 200 -
INFO:root:POST request,
Path: /
Headers:
X-CS-Event-ID: fe9fbb8a-d83b-42c2-a56c-fd1a32542ba8
X-CS-Event: TEST.WEBHOOK
User-Agent: CS-Hookshot/4eb654e3-d670-11f0-ab6d-1e00300001db
Content-Length: 4
Content-Type: text/plain; charset=ISO-8859-1
Host: 10.0.33.232:8080
Connection: Keep-Alive
Accept-Encoding: gzip,deflate
Body:
test
After fix
Path: /
Headers:
X-CS-Event-ID: 0c869b00-a8bd-4994-b338-741f19050712
X-CS-Event: TEST.WEBHOOK
User-Agent: CS-Hookshot/70b2ee78-e55b-11f0-8971-1e00f1000481
Content-Length: 26
Content-Type: application/json; charset=UTF-8
Host: 10.0.33.232:8080
Connection: Keep-Alive
Accept-Encoding: gzip,deflate
Body:
{'CloudStack': 'works!'}
Screenshot
10.0.35.238 - - [30/Dec/2025 09:34:40] "POST / HTTP/1.1" 200 -
WARNING:root:Rejected POST due to unsupported Content-Type: text/plain; charset=ISO-8859-1
used sample HTTP server code
https://gist.github.com/shwstppr/5672c98a3a598b378e6c582c68b0e0ce
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Description
Fixes #12317
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?
Without change:
With change: