linstor: Provide /dev/drbd/by-res/ resource paths to CloudStack

[rp-]

Description

Instead of providing the very basic /dev/drbd{minorNr} drbd block device path provide the
by-res path, that also includes the cloudstack volume.path

Prerequisite for #12218

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Spun up a fresh Linstor cluster, and checked the new path is used in the libvirt xml

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

❌ Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.23%. Comparing base (e8200a0) to head (49d3e54).
⚠️ Report is 8 commits behind head on 4.20.

Files with missing lines	Patch %	Lines
...cloudstack/storage/datastore/util/LinstorUtil.java	0.00%	12 Missing ⚠️
.../hypervisor/kvm/storage/LinstorStorageAdaptor.java	0.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.20   #12300   +/-   ##
=========================================
  Coverage     16.23%   16.23%           
- Complexity    13371    13375    +4     
=========================================
  Files          5657     5657           
  Lines        498860   498869    +9     
  Branches      60543    60544    +1     
=========================================
+ Hits          81003    81006    +3     
- Misses       408824   408831    +7     
+ Partials       9033     9032    -1     

Flag	Coverage Δ
uitests	4.00% <ø> (ø)
unittests	17.09% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[DaanHoogland]

clgtm

[rp-]

@DaanHoogland sorry I missed to locations.

[DaanHoogland]

@DaanHoogland sorry I missed to locations.

but these are all?

[rp-]

@DaanHoogland sorry I missed to locations.

but these are all?

yes, all now

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16110

[DaanHoogland]

@abh1sar , is there any testing anybody but @rp- can do on this, or do we settle for gha? (I do not think smoke tests are touching anything relevant)

[abh1sar]

@abh1sar , is there any testing anybody but @rp- can do on this, or do we settle for gha? (I do not think smoke tests are touching anything relevant)

Not sure @DaanHoogland . My first attempt to setup Linstor failed. @rp- do you have any pointers for testing? I don't think the packages are available publicly. I tried building from source but hit a blocker.

[rp-]

@abh1sar

We host a public PPA with ready packages here: https://launchpad.net/~linbit/+archive/ubuntu/linbit-drbd9-stack
if you test on different distributions, I can help you get started, you can also hit me on slack if you want.

[abh1sar]

@abh1sar

We host a public PPA with ready packages here: https://launchpad.net/~linbit/+archive/ubuntu/linbit-drbd9-stack if you test on different distributions, I can help you get started, you can also hit me on slack if you want.

Thanks @rp- . I will give it a try tomorrow.

[abh1sar]

Verified.

domblklist gives the by-res/cs-{vol-uuid} path

It points to the actual block device

path has the volume uuids

Should this go into 4.20 or main, considering this is an enhancement, although small? cc @rp- @DaanHoogland

[DaanHoogland]

Should this go into 4.20 or main, considering this is an enhancement, although small? cc @rp- @DaanHoogland

@abh1sar , as we are not taking responsibility of the 3rd party component, our only consideration would be “are there update requirements?”. Other than that it is up to the 3rd party provider (@rp- in this case) and I try not to care. Viewpoints may differ of course. Do you have any concern with this PR?

[abh1sar]

@abh1sar , as we are not taking responsibility of the 3rd party component, our only consideration would be “are there update requirements?”. Other than that it is up to the 3rd party provider (@rp- in this case) and I try not to care. Viewpoints may differ of course. Do you have any concern with this PR?

Thanks @DaanHoogland. No concerns. I have tested it, this is good to go from my side.

[abh1sar]

LGTM