api: create/register/upload template with empty template tag

[weizhouapache]

Description

This PR fixes an issue when register/create/upload a template

• set a template tag, then chean it on UI
• the template is registered with tag "", not NULL
• it causes the vm deployment to fail

with this PR, template tag will be NULL

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 4.00%. Comparing base (4348386) to head (b950440).
⚠️ Report is 5 commits behind head on 4.20.

Files with missing lines	Patch %	Lines
...k/api/command/user/template/CreateTemplateCmd.java	0.00%	1 Missing ⚠️
...d/user/template/GetUploadParamsForTemplateCmd.java	0.00%	1 Missing ⚠️
...api/command/user/template/RegisterTemplateCmd.java	0.00%	1 Missing ⚠️
...om/cloud/consoleproxy/ConsoleProxyManagerImpl.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##               4.20   #12234       +/-   ##
=============================================
- Coverage     16.21%    4.00%   -12.22%     
=============================================
  Files          5657      402     -5255     
  Lines        498647    32677   -465970     
  Branches      60533     5812    -54721     
=============================================
- Hits          80863     1309    -79554     
+ Misses       408771    31213   -377558     
+ Partials       9013      155     -8858     

Flag	Coverage Δ
uitests	4.00% <ø> (ø)
unittests	17.07% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[DaanHoogland]

code lgtm, was there an issue associated with this @weizhouapache ?

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15998

[weizhouapache]

code lgtm, was there an issue associated with this @weizhouapache ?

I did not create a github issue.

I have faced the issue since several years ago that some vm templates have template tag as "", not NULL, which confused me.
I think this fixes it.

[sureshanaparti]

clgtm

[RosiKyu]

LGTM

The fix works correctly - it properly catches both empty strings and whitespace-only strings, converting them to NULL which allows VM deployment to succeed.

Test Cases Executed:

• Register template with empty tag (templatetag="") → stored as NULL - PASS
• Register template with whitespace-only tag (templatetag=" ") → stored as NULL - PASS
• Register template with valid tag (templatetag="my-valid-tag") → stored correctly - PASS
• VM deployment from template with empty tag → VM running - PASS

Evidence

VM deployed

(localcloud) 🐱 > deploy virtualmachine serviceofferingid="5d2b9b28-1bff-4b46-ab6f-878294298e3b" templateid="681009e5-ee32-4694-804c-e848ea0e5bec" zoneid="1acdbdba-d51a-4b71-9b6e-cf302454459d" name="vm-from-empty-tag-template"
{
  "virtualmachine": {
    "account": "admin",
    "affinitygroup": [],
    "arch": "x86_64",
    "cpunumber": 1,
    "cpuspeed": 500,
    "created": "2025-12-13T13:36:25+0000",
    "deleteprotection": false,
    "details": {
      "cpuOvercommitRatio": "2.0"
    },
    "displayname": "vm-from-empty-tag-template",
    "displayvm": true,
    "domain": "ROOT",
    "domainid": "14020525-d813-11f0-98a0-1e00d40003ba",
    "domainpath": "/",
    "guestosid": "36370517-d813-11f0-98a0-1e00d40003ba",
    "haenable": false,
    "hasannotations": false,
    "hostcontrolstate": "Enabled",
    "hostid": "71445e5d-af50-4bce-b545-5f768fd60837",
    "hostname": "ref-trl-10391-k-Mol8-rositsa-kyuchukova-kvm2",
    "hypervisor": "KVM",
    "id": "e05ad3e2-6fe2-4384-bc2f-a4d24da32a7a",
    "instancename": "i-2-3-VM",
    "ipaddress": "10.1.1.100",
    "isdynamicallyscalable": false,
    "jobid": "c9df5475-f042-4a83-974b-9589e9def7b5",
    "jobstatus": 0,
    "lastupdated": "2025-12-13T13:37:20+0000",
    "memory": 512,
    "name": "vm-from-empty-tag-template",
    "nic": [
      {
        "broadcasturi": "vlan://1844",
        "deviceid": "0",
        "extradhcpoption": [],
        "gateway": "10.1.1.1",
        "id": "0818119d-2d21-456f-a86f-a3bbdd15afaf",
        "ipaddress": "10.1.1.100",
        "isdefault": true,
        "isolationuri": "vlan://1844",
        "macaddress": "02:01:00:cc:00:01",
        "netmask": "255.255.255.0",
        "networkid": "265861c3-73d1-4a5f-9d9a-688a392b371f",
        "networkname": "admin-network",
        "secondaryip": [],
        "traffictype": "Guest",
        "type": "Isolated"
      }
    ],
    "osdisplayname": "Debian GNU/Linux 9 (64-bit)",
    "ostypeid": "36370517-d813-11f0-98a0-1e00d40003ba",
    "passwordenabled": false,
    "pooltype": "NetworkFilesystem",
    "receivedbytes": 0,
    "rootdeviceid": 0,
    "rootdevicetype": "ROOT",
    "securitygroup": [],
    "sentbytes": 0,
    "serviceofferingid": "5d2b9b28-1bff-4b46-ab6f-878294298e3b",
    "serviceofferingname": "Small Instance",
    "state": "Running",
    "tags": [],
    "templatedisplaytext": "Test Empty Tag",
    "templateformat": "QCOW2",
    "templateid": "681009e5-ee32-4694-804c-e848ea0e5bec",
    "templatename": "test-empty-tag",
    "templatetype": "USER",
    "userid": "4db2db97-d813-11f0-98a0-1e00d40003ba",
    "username": "admin",
    "zoneid": "1acdbdba-d51a-4b71-9b6e-cf302454459d",
    "zonename": "ref-trl-10391-k-Mol8-rositsa-kyuchukova"
  }
}

[RosiKyu]

@blueorangutan test

[blueorangutan]

@RosiKyu a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian Build Failed (tid-14979)

[weizhouapache]

@blueorangutan test

[blueorangutan]

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-14980)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 52235 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12234-t14980-kvm-ol8.zip
Smoke tests completed. 135 look OK, 6 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_DeployVmAntiAffinityGroup_in_project	Error	103.96	test_affinity_groups_projects.py
test_DeployVmAntiAffinityGroup	Error	39.68	test_affinity_groups.py
test_03_deploy_and_scale_kubernetes_cluster	Failure	28.74	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	Failure	0.07	test_kubernetes_clusters.py
test_01_non_strict_host_anti_affinity	Failure	140.37	test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity	Error	91.43	test_nonstrict_affinity_group.py
ContextSuite context=TestMigrateVMStrictTags>:setup	Error	0.00	test_vm_strict_host_tags.py
test_hostha_enable_ha_when_host_in_maintenance	Error	305.82	test_hostha_kvm.py

[weizhouapache]

@blueorangutan test

[blueorangutan]

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-14996)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 49266 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12234-t14996-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File