Fix agent wait before reconnect

[sureshanaparti]

Description

There is a regression in 4.20.1 & 4.20.2 which is resulting in the issue #8517.

This PR fixes the agent wait before reconnect, applies the fix in #9258 with minor log updates.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Patched the agent changes to 4.20.2 env with 3 kvm hosts, and restarted agents in all the kvm hosts. Verfied the CPU util in MS.

How did you try to break this feature and the system with this change?

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.18%. Comparing base (4dc3931) to head (5656b70).
⚠️ Report is 18 commits behind head on 4.20.

Files with missing lines	Patch %	Lines
agent/src/main/java/com/cloud/agent/Agent.java	0.00%	6 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.20   #12153      +/-   ##
============================================
- Coverage     16.18%   16.18%   -0.01%     
+ Complexity    13304    13301       -3     
============================================
  Files          5657     5657              
  Lines        498464   498478      +14     
  Branches      60491    60501      +10     
============================================
- Hits          80695    80667      -28     
- Misses       408787   408827      +40     
- Partials       8982     8984       +2     

Flag	Coverage Δ
uitests	4.00% <ø> (-0.01%)	⬇️
unittests	17.03% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15842

[sureshanaparti]

@blueorangutan test

[blueorangutan]

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-14873)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 52944 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12153-t14873-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[rajujith]

LGTM
Tested , this resolved the issue. However I would suggest adding autoshutdown after a timeout , unconfigure the agent probably by moving the agent.properties to a backup file and stopping the agent on removal from management server as a separate improvement in future versions.

[weizhouapache]

code lgtm

[weizhouapache]

LGTM Tested , this resolved the issue. However I would suggest adding autoshutdown after a timeout , unconfigure the agent probably by moving the agent.properties to a backup file and stopping the agent on removal from management server as a separate improvement in future versions.

make sense.
agent can be stopped after some specific issues happen several times.

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15886