server: fix remove management server

[shwstppr]

Description

Fixes #12137

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

In a 2 MS environment, stopped one of the server and tried to remove that

(localcloud) 🐱 > list managementservers filter=id,name,state
{
  "count": 2,
  "managementserver": [
    {
      "id": "4737741d-c7b4-421c-a04d-dd2f0e2cd720",
      "name": "pr12151-t14874-kvm-ol8-mgmt1.sofia.shapeblue.com",
      "state": "Up"
    },
    {
      "id": "6995c1f6-943e-42d8-a430-b6933992ec3a",
      "name": "pr12151-t14874-kvm-ol8-mgmt2.sofia.shapeblue.com",
      "state": "Up"
    }
  ]
}
(localcloud) 🐱 > remove managementserver id=6995c1f6-943e-42d8-a430-b6933992ec3a 
🙈 Error: (HTTP 431, error code 4350) Unable to remove Management Server with ID [6995c1f6-943e-42d8-a430-b6933992ec3a]. It can only be removed when it is in the [Down] state, however currently it is in the [Up] state.
(localcloud) 🐱 > list managementservers filter=id,name,state
{
  "count": 2,
  "managementserver": [
    {
      "id": "4737741d-c7b4-421c-a04d-dd2f0e2cd720",
      "name": "pr12151-t14874-kvm-ol8-mgmt1.sofia.shapeblue.com",
      "state": "Up"
    },
    {
      "id": "6995c1f6-943e-42d8-a430-b6933992ec3a",
      "name": "pr12151-t14874-kvm-ol8-mgmt2.sofia.shapeblue.com",
      "state": "Down"
    }
  ]
}
(localcloud) 🐱 > remove managementserver id=6995c1f6-943e-42d8-a430-b6933992ec3a 
{
  "success": true
}

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 17.56%. Comparing base (671d8ad) to head (896e321).
⚠️ Report is 117 commits behind head on 4.22.

Files with missing lines	Patch %	Lines
...in/java/com/cloud/server/ManagementServerImpl.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.22   #12147   +/-   ##
=========================================
  Coverage     17.55%   17.56%           
- Complexity    15536    15546   +10     
=========================================
  Files          5909     5910    +1     
  Lines        529118   529123    +5     
  Branches      64627    64627           
=========================================
+ Hits          92902    92934   +32     
+ Misses       425761   425735   -26     
+ Partials      10455    10454    -1     

Flag	Coverage Δ
uitests	3.58% <ø> (+<0.01%)	⬆️
unittests	18.63% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[shwstppr]

@blueorangutan package

[blueorangutan]

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15837

[DaanHoogland]

this slipped through the regression test nets I think, clgtm

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-14902)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 51230 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12147-t14902-kvm-ol8.zip
Smoke tests completed. 149 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[DaanHoogland]

@nicoschmdt , can you please review?

[harikrishna-patnala]

code LGTM

[blueorangutan]

[SF] Trillian Build Failed (tid-15296)