UI: fix list of zones if zone has icon

[weizhouapache]

Description

This PR fixes an issue on UI

• upload icon of zone
• open the vm deployment wizard

the list of zones ia empty, browser throws an error

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[weizhouapache]

@blueorangutan ui

[blueorangutan]

@weizhouapache a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.56%. Comparing base (50fe265) to head (52b93f8).
⚠️ Report is 5 commits behind head on 4.22.

Additional details and impacted files

@@            Coverage Diff            @@
##               4.22   #12083   +/-   ##
=========================================
  Coverage     17.55%   17.56%           
- Complexity    15535    15540    +5     
=========================================
  Files          5909     5909           
  Lines        529053   529097   +44     
  Branches      64619    64624    +5     
=========================================
+ Hits          92879    92914   +35     
- Misses       425719   425729   +10     
+ Partials      10455    10454    -1     

Flag	Coverage Δ
uitests	3.58% <ø> (-0.01%)	⬇️
unittests	18.62% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[shwstppr]

@blueorangutan ui

[blueorangutan]

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/12083 (QA-JID-806)

[DaanHoogland]

clgtm, though I cannot see the error before the fix.

[shwstppr]

@DaanHoogland cc @weizhouapache I think it would need more than 8 zones to reproduce this, as the related typo is when Zone selection needs to show select box

[DaanHoogland]

@DaanHoogland cc @weizhouapache I think it would need more than 8 zones to reproduce this, as the related typo is when Zone selection needs to show select box

thanks @shwstppr , I’ll extend my test a bit ;)

[DaanHoogland]

verified with 9 zones in qa