Skip to content

webhook: fixes, filter enhancement #12023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DaanHoogland merged 16 commits into from
Jan 5, 2026

fix conflicting check

6b5f2c2
Select commit
Loading
Failed to load commit list.
Merged

webhook: fixes, filter enhancement #12023

fix conflicting check
6b5f2c2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 3, 2026 in 0s

17.76% (+0.25%) compared to 5bf869c

View this Pull Request on Codecov

17.76% (+0.25%) compared to 5bf869c

Details

Codecov Report

❌ Patch coverage is 71.86047% with 121 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.76%. Comparing base (5bf869c) to head (6b5f2c2).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...che/cloudstack/mom/webhook/vo/WebhookFilterVO.java 38.33% 36 Missing and 1 partial ⚠️
...g/apache/cloudstack/mom/webhook/WebhookFilter.java 35.18% 22 Missing and 13 partials ⚠️
.../cloudstack/mom/webhook/WebhookApiServiceImpl.java 86.04% 6 Missing and 12 partials ⚠️
...che/cloudstack/mom/webhook/WebhookServiceImpl.java 80.59% 4 Missing and 9 partials ⚠️
.../webhook/api/command/user/AddWebhookFilterCmd.java 80.00% 6 Missing ⚠️
...bhook/api/command/user/DeleteWebhookFilterCmd.java 68.42% 6 Missing ⚠️
...oudstack/mom/webhook/dao/WebhookFilterDaoImpl.java 81.25% 0 Missing and 6 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #12023      +/-   ##
============================================
+ Coverage     17.51%   17.76%   +0.25%     
- Complexity    15585    15858     +273     
============================================
  Files          5914     5923       +9     
  Lines        529867   530451     +584     
  Branches      64722    64815      +93     
============================================
+ Hits          92782    94228    +1446     
+ Misses       426635   425682     -953     
- Partials      10450    10541      +91

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov