Skip to content

import network acl rules using csv #12013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DaanHoogland merged 7 commits into from
Jan 29, 2026

resolve conflict

e251cec
Select commit
Loading
Failed to load commit list.
Merged

import network acl rules using csv #12013

resolve conflict
e251cec
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jan 14, 2026 in 0s

17.58% (-0.01%) compared to 55ab7c5

View this Pull Request on Codecov

17.58% (-0.01%) compared to 55ab7c5

Details

Codecov Report

❌ Patch coverage is 0% with 130 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.58%. Comparing base (55ab7c5) to head (e251cec).
⚠️ Report is 32 commits behind head on 4.22.

Files with missing lines Patch % Lines
...a/com/cloud/network/vpc/NetworkACLServiceImpl.java 0.00% 71 Missing ⚠️
.../api/command/user/network/ImportNetworkACLCmd.java 0.00% 38 Missing ⚠️
.../api/command/user/network/CreateNetworkACLCmd.java 0.00% 20 Missing ⚠️
...in/java/com/cloud/server/ManagementServerImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               4.22   #12013      +/-   ##
============================================
- Coverage     17.59%   17.58%   -0.01%     
  Complexity    15595    15595              
============================================
  Files          5910     5912       +2     
  Lines        529606   529844     +238     
  Branches      64705    64741      +36     
============================================
  Hits          93178    93178              
- Misses       425940   426178     +238     
  Partials      10488    10488

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov