Initialize template status='Processing' by sudo87 · Pull Request #11970 · apache/cloudstack

sudo87 · 2025-11-04T06:45:24Z

Description

This PR fixes #11125

API response for template/iso registration will have status="Processing"

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

server/src/main/java/com/cloud/api/query/dao/TemplateJoinDaoImpl.java

sudo87 · 2025-11-04T07:07:38Z

@blueorangutan package

blueorangutan · 2025-11-04T07:08:04Z

@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov · 2025-11-04T07:08:22Z

Codecov Report

❌ Patch coverage is 30.55556% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.24%. Comparing base (b394b5b) to head (a7b4969).
⚠️ Report is 62 commits behind head on 4.20.

Files with missing lines	Patch %	Lines
...a/com/cloud/api/query/dao/TemplateJoinDaoImpl.java	30.55%	25 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.20   #11970   +/-   ##
=========================================
  Coverage     16.23%   16.24%           
- Complexity    13377    13379    +2     
=========================================
  Files          5657     5657           
  Lines        498865   498872    +7     
  Branches      60545    60543    -2     
=========================================
+ Hits          80991    81023   +32     
+ Misses       408843   408816   -27     
- Partials       9031     9033    +2

Flag	Coverage Δ
uitests	`4.00% <ø> (ø)`
unittests	`17.09% <30.55%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

blueorangutan · 2025-11-04T08:34:17Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15626

sureshanaparti

clgtm

sureshanaparti · 2025-11-04T08:37:46Z

@blueorangutan package

blueorangutan · 2025-11-04T08:40:05Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Copilot

Pull Request Overview

This PR refactors the getTemplateStatus() method in TemplateJoinDaoImpl to improve code readability and maintainability by simplifying the conditional logic and removing dead code.

Restructured the conditional logic with an early return for the DOWNLOADED state
Changed error string validation from null check to StringUtils.isNotBlank()
Removed unreachable "Successfully Installed" code path

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

server/src/main/java/com/cloud/api/query/dao/TemplateJoinDaoImpl.java

sudo87 · 2025-11-04T09:37:05Z

@blueorangutan package

blueorangutan · 2025-11-04T09:38:04Z

@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-11-04T10:44:21Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15630

blueorangutan · 2025-11-04T10:58:48Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15632

server/src/main/java/com/cloud/api/query/dao/TemplateJoinDaoImpl.java

sudo87 · 2025-11-05T09:15:05Z

@blueorangutan package

blueorangutan · 2025-11-05T09:18:04Z

@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-11-05T10:32:31Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15640

DaanHoogland

clgtm

RosiKyu · 2025-12-10T19:53:21Z

@blueorangutan package

blueorangutan · 2025-12-10T19:54:04Z

@rosi-shapeblue a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

sudo87 · 2025-12-23T06:14:29Z

@blueorangutan package

blueorangutan · 2025-12-23T06:16:03Z

@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-12-23T07:28:32Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16138

sudo87 · 2025-12-24T11:41:13Z

@blueorangutan package

blueorangutan · 2025-12-24T11:42:04Z

@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-12-24T12:52:35Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16158

sudo87 · 2025-12-25T06:45:25Z

@blueorangutan test

blueorangutan · 2025-12-25T06:46:04Z

@sudo87 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-12-27T15:50:18Z

[SF] Trillian test result (tid-15063)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 202338 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11970-t15063-kvm-ol8.zip
Smoke tests completed. 91 look OK, 50 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestAccounts>:setup	`Error`	0.00	test_accounts.py
ContextSuite context=TestTemplateHierarchy>:setup	`Error`	1548.18	test_accounts.py
ContextSuite context=TestDeployVmWithAffinityGroup>:setup	`Error`	0.00	test_affinity_groups_projects.py
ContextSuite context=TestAnnotations>:setup	`Error`	0.00	test_annotations.py
test_query_async_job_result	`Error`	0.00	test_async_job.py
ContextSuite context=TestInternalLb>:setup	`Error`	0.00	test_internal_lb.py
ContextSuite context=TestDeployVmWithVariedPlanners>:setup	`Error`	0.00	test_deploy_vms_with_varied_deploymentplanners.py
ContextSuite context=TestDeployVirtioSCSIVM>:setup	`Error`	0.00	test_deploy_virtio_scsi_vm.py
ContextSuite context=TestDeployVmWithUserData>:setup	`Error`	0.00	test_deploy_vm_with_userdata.py
ContextSuite context=TestDeployVMFromISO>:setup	`Error`	0.00	test_deploy_vm_iso.py
ContextSuite context=TestIpv4Routing>:setup	`Error`	0.00	test_ipv4_routing.py
ContextSuite context=TestDeployVMsInParallel>:setup	`Error`	0.00	test_deploy_vms_in_parallel.py
ContextSuite context=TestRemoteDiagnostics>:setup	`Error`	0.00	test_diagnostics.py
ContextSuite context=TestDomainsServiceOfferings>:setup	`Error`	1529.39	test_domain_service_offerings.py
test_01_browser_migrate_template	`Error`	75.85	test_image_store_object_migration.py
ContextSuite context=TestListIdsParams>:setup	`Error`	0.00	test_list_ids_parameter.py
ContextSuite context=TestLoadBalance>:setup	`Error`	0.00	test_loadbalance.py
ContextSuite context=TestMetrics>:setup	`Error`	0.00	test_metrics_api.py
test_nic_secondaryip_add_remove	`Error`	1525.90	test_multipleips_per_nic.py
ContextSuite context=TestIsolatedNetworksPasswdServer>:setup	`Error`	0.00	test_password_server.py
ContextSuite context=TestNestedVirtualization>:setup	`Error`	0.00	test_nested_virtualization.py
ContextSuite context=TestNetworkACL>:setup	`Error`	0.00	test_network_acl.py
ContextSuite context=TestIpv6Network>:setup	`Error`	0.00	test_network_ipv6.py
test_delete_account	`Error`	1525.75	test_network.py
ContextSuite context=TestSharedNetworkWithConfigDrive>:setup	`Error`	1520.23	test_network.py
ContextSuite context=TestAdapterTypeForNic>:setup	`Error`	0.00	test_nic_adapter_type.py
ContextSuite context=TestNonStrictAffinityGroups>:setup	`Error`	0.00	test_nonstrict_affinity_group.py
ContextSuite context=TestPortForwardingRules>:setup	`Error`	0.00	test_portforwardingrules.py
ContextSuite context=TestPrivateGwACL>:setup	`Error`	0.00	test_privategw_acl.py
ContextSuite context=TestProjectSuspendActivate>:setup	`Error`	1539.08	test_projects.py
test_CRUD_operations_userdata	`Error`	1532.61	test_register_userdata.py
ContextSuite context=TestResetVmOnReboot>:setup	`Error`	0.00	test_reset_vm_on_reboot.py
ContextSuite context=TestRAMCPUResourceAccounting>:setup	`Error`	0.00	test_resource_accounting.py
ContextSuite context=TestRestoreVM>:setup	`Error`	0.00	test_restore_vm.py
ContextSuite context=TestRouterDHCPHosts>:setup	`Error`	0.00	test_router_dhcphosts.py
ContextSuite context=TestRouterDns>:setup	`Error`	0.00	test_router_dns.py
ContextSuite context=TestRouterDnsService>:setup	`Error`	0.00	test_router_dnsservice.py
ContextSuite context=TestRouterIpTablesPolicies>:setup	`Error`	0.00	test_routers_iptables_default_policy.py
ContextSuite context=TestIsolatedNetworks>:setup	`Error`	0.00	test_routers_network_ops.py
ContextSuite context=TestRouterServices>:setup	`Error`	0.00	test_routers.py
ContextSuite context=TestCpuCapServiceOfferings>:setup	`Error`	0.00	test_service_offerings.py
ContextSuite context=TestSetSourceNatIp>:setup	`Error`	0.00	test_set_sourcenat.py
ContextSuite context=TestSnapshotRootDisk>:setup	`Error`	0.00	test_snapshots.py
ContextSuite context=TestSnapshotStandaloneBackup>:setup	`Error`	0.00	test_snapshots.py
ContextSuite context=TestVMWareStoragePolicies>:setup	`Error`	0.00	test_storage_policy.py
test_02_create_template_with_checksum_sha1	`Error`	65.63	test_templates.py
test_03_create_template_with_checksum_sha256	`Error`	90.90	test_templates.py
test_04_create_template_with_checksum_md5	`Error`	65.62	test_templates.py
test_05_create_template_with_no_checksum	`Error`	65.68	test_templates.py
ContextSuite context=TestMigrateVMStrictTags>:setup	`Error`	0.00	test_vm_strict_host_tags.py
ContextSuite context=TestRestoreVMStrictTags>:setup	`Error`	0.00	test_vm_strict_host_tags.py
ContextSuite context=TestScaleVMStrictTags>:setup	`Error`	0.00	test_vm_strict_host_tags.py
ContextSuite context=TestVMDeploymentPlannerStrictTags>:setup	`Error`	0.00	test_vm_strict_host_tags.py
test_04_deploy_vnf_appliance	`Error`	311.87	test_vnf_templates.py
ContextSuite context=TestIpv6Vpc>:setup	`Error`	0.00	test_vpc_ipv6.py
ContextSuite context=TestVPCRedundancy>:setup	`Error`	0.00	test_vpc_redundant.py
ContextSuite context=TestVPCNics>:setup	`Error`	0.00	test_vpc_router_nics.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup	`Error`	0.00	test_vpc_vpn.py
test_disable_oobm_ha_state_ineligible	`Error`	1531.54	test_hostha_kvm.py

sudo87 · 2025-12-30T10:04:26Z

@blueorangutan package

blueorangutan · 2025-12-30T10:06:04Z

@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-12-30T11:11:02Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16210

sudo87 · 2025-12-30T11:14:44Z

@blueorangutan test

blueorangutan · 2025-12-30T11:16:03Z

@sudo87 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-12-30T12:21:28Z

[SF] Trillian Build Failed (tid-15085)

sudo87 · 2025-12-31T04:01:53Z

@blueorangutan test

blueorangutan · 2025-12-31T04:04:04Z

@sudo87 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-12-31T18:15:05Z

[SF] Trillian test result (tid-15090)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 48364 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11970-t15090-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

DaanHoogland · 2026-01-05T06:18:48Z

@bernardodemarco , are all you reservations addressed?

Initialize template status='Processing'

2add1ba

sureshanaparti reviewed Nov 4, 2025

View reviewed changes

server/src/main/java/com/cloud/api/query/dao/TemplateJoinDaoImpl.java Show resolved Hide resolved

sudo87 added 2 commits November 4, 2025 13:32

remove else block and fix the error string

ef29e99

restructure if-else

a4cca72

sureshanaparti approved these changes Nov 4, 2025

View reviewed changes

sureshanaparti added the status:needs-testing label Nov 4, 2025

sureshanaparti linked an issue Nov 4, 2025 that may be closed by this pull request

Initial status of Template/ISO is empty ("") upon creation #11125

Closed

sureshanaparti requested a review from Copilot November 4, 2025 08:42

Copilot AI reviewed Nov 4, 2025

View reviewed changes

server/src/main/java/com/cloud/api/query/dao/TemplateJoinDaoImpl.java Outdated Show resolved Hide resolved

DaanHoogland mentioned this pull request Nov 4, 2025

Initial status of Template/ISO is empty ("") upon creation #11125

Closed

standardize register ISO response

c67e7d0

bernardodemarco reviewed Nov 4, 2025

View reviewed changes

server/src/main/java/com/cloud/api/query/dao/TemplateJoinDaoImpl.java Outdated Show resolved Hide resolved

use enum instead of string

abed121

DaanHoogland approved these changes Nov 6, 2025

View reviewed changes

DaanHoogland assigned RosiKyu Nov 11, 2025

Merge branch 'b_4.20' into fixDownloadTemplateStatus

a3e995e

fix smoke test failures

21828b3

boring-cyborg bot added component:marvin Python Warning... Python code Ahead! labels Dec 24, 2025

Add Download Complete status for template

a7b4969

DaanHoogland approved these changes Dec 30, 2025

View reviewed changes

abh1sar added this to the 4.20.3 milestone Jan 7, 2026

RosiKyu assigned RosiKyu and unassigned RosiKyu Jan 27, 2026

borisstoyanov merged commit af9d686 into apache:4.20 Jan 27, 2026
42 of 43 checks passed

RosiKyu removed the status:waiting-for-smoketest-results label Jan 27, 2026

Conversation

sudo87 commented Nov 4, 2025

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

Uh oh!

sudo87 commented Nov 4, 2025

Uh oh!

blueorangutan commented Nov 4, 2025

Uh oh!

codecov bot commented Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented Nov 4, 2025

Uh oh!

sureshanaparti left a comment

Choose a reason for hiding this comment

Uh oh!

sureshanaparti commented Nov 4, 2025

Uh oh!

blueorangutan commented Nov 4, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

sudo87 commented Nov 4, 2025

Uh oh!

blueorangutan commented Nov 4, 2025

Uh oh!

blueorangutan commented Nov 4, 2025

Uh oh!

blueorangutan commented Nov 4, 2025

Uh oh!

Uh oh!

sudo87 commented Nov 5, 2025

Uh oh!

blueorangutan commented Nov 5, 2025

Uh oh!

blueorangutan commented Nov 5, 2025

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

RosiKyu commented Dec 10, 2025

Uh oh!

blueorangutan commented Dec 10, 2025

Uh oh!

sudo87 commented Dec 23, 2025

Uh oh!

blueorangutan commented Dec 23, 2025

Uh oh!

blueorangutan commented Dec 23, 2025

Uh oh!

sudo87 commented Dec 24, 2025

Uh oh!

blueorangutan commented Dec 24, 2025

Uh oh!

blueorangutan commented Dec 24, 2025

Uh oh!

sudo87 commented Dec 25, 2025

Uh oh!

blueorangutan commented Dec 25, 2025

Uh oh!

blueorangutan commented Dec 27, 2025

Uh oh!

sudo87 commented Dec 30, 2025

Uh oh!

blueorangutan commented Dec 30, 2025

Uh oh!

blueorangutan commented Dec 30, 2025

Uh oh!

codecov bot commented Nov 4, 2025 •

edited

Loading