Skip to content

[VMware to KVM Migration] Fix unused convert env vars #11947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nvazquez merged 4 commits into from
Feb 26, 2026

Address review comments

1a64f64
Select commit
Loading
Failed to load commit list.
Merged

[VMware to KVM Migration] Fix unused convert env vars #11947

Address review comments
1a64f64
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 27, 2026 in 1s

17.59% (+0.00%) compared to b8ed34e

View this Pull Request on Codecov

17.59% (+0.00%) compared to b8ed34e

Details

Codecov Report

❌ Patch coverage is 42.85714% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.59%. Comparing base (b8ed34e) to head (1a64f64).
⚠️ Report is 60 commits behind head on 4.22.

Files with missing lines Patch % Lines
...ervisor/kvm/resource/LibvirtComputingResource.java 14.28% 6 Missing ⚠️
...s/src/main/java/com/cloud/utils/script/Script.java 60.00% 2 Missing and 2 partials ⚠️
.../wrapper/LibvirtConvertInstanceCommandWrapper.java 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##               4.22   #11947   +/-   ##
=========================================
  Coverage     17.59%   17.59%           
- Complexity    15600    15602    +2     
=========================================
  Files          5910     5910           
  Lines        529755   529767   +12     
  Branches      64724    64726    +2     
=========================================
+ Hits          93228    93235    +7     
- Misses       426035   426038    +3     
- Partials      10492    10494    +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov