-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add cloud image downloader script #11918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11918 +/- ##
============================================
- Coverage 17.85% 17.85% -0.01%
+ Complexity 15998 15997 -1
============================================
Files 5930 5930
Lines 531441 531441
Branches 64973 64973
============================================
- Hits 94890 94879 -11
- Misses 425924 425937 +13
+ Partials 10627 10625 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c3c8725 to
6a98dd4
Compare
DaanHoogland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested manually in production 😶🌫️ and clgtm
shwstppr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
@sudo87 can you please check the outstanding comments?
|
Thank you @shwstppr for your review, resolved the last comment as well. PR is ready for merge. |
shwstppr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor re-ordering, then maybe we can merge
|
Thank you @shwstppr for the suggestion, pr is updated. Reordered the keys by distro version and keeing x86_64 first. |
39912df to
656b99b
Compare
Co-authored-by: dahn <daan.hoogland@gmail.com>
Co-authored-by: dahn <daan.hoogland@gmail.com>
a9e6347 to
3e7994a
Compare
|
@blueorangutan package |
Description
This PR adds cloud image downloader script. It will be setup as cron job to periodically refresh cloud images located at https://download.cloudstack.org/templates/cloud-images.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?