Skip to content

Conversation

@sudo87
Copy link
Collaborator

@sudo87 sudo87 commented Oct 28, 2025

Description

This PR adds cloud image downloader script. It will be setup as cron job to periodically refresh cloud images located at https://download.cloudstack.org/templates/cloud-images.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@sudo87 sudo87 requested a review from DaanHoogland October 28, 2025 10:16
@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.85%. Comparing base (98debd2) to head (3e7994a).

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #11918      +/-   ##
============================================
- Coverage     17.85%   17.85%   -0.01%     
+ Complexity    15998    15997       -1     
============================================
  Files          5930     5930              
  Lines        531441   531441              
  Branches      64973    64973              
============================================
- Hits          94890    94879      -11     
- Misses       425924   425937      +13     
+ Partials      10627    10625       -2     
Flag Coverage Δ
uitests 3.58% <ø> (ø)
unittests 18.94% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sudo87 sudo87 closed this Oct 28, 2025
@sudo87 sudo87 reopened this Oct 28, 2025
@DaanHoogland DaanHoogland added this to the 4.23 milestone Oct 28, 2025
@sudo87 sudo87 force-pushed the cloudImageDownloader branch from c3c8725 to 6a98dd4 Compare October 28, 2025 17:08
@sudo87 sudo87 requested a review from DaanHoogland October 29, 2025 04:03
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested manually in production 😶‍🌫️ and clgtm

Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@sudo87 can you please check the outstanding comments?

@sudo87
Copy link
Collaborator Author

sudo87 commented Jan 28, 2026

Thank you @shwstppr for your review, resolved the last comment as well. PR is ready for merge.

Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor re-ordering, then maybe we can merge

@sudo87
Copy link
Collaborator Author

sudo87 commented Jan 29, 2026

Thank you @shwstppr for the suggestion, pr is updated. Reordered the keys by distro version and keeing x86_64 first.

@sudo87 sudo87 force-pushed the cloudImageDownloader branch from a9e6347 to 3e7994a Compare January 29, 2026 05:11
@DaanHoogland
Copy link
Contributor

@blueorangutan package

@DaanHoogland
Copy link
Contributor

@sudo87 @shwstppr , do we need to ask someone to test the script (again)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants