-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Remove unnecessary stubbings in ManagementServerMaintenanceManagerImplTest #11914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary stubbings in ManagementServerMaintenanceManagerImplTest #11914
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11914 +/- ##
=========================================
Coverage 17.56% 17.56%
+ Complexity 15542 15538 -4
=========================================
Files 5909 5909
Lines 529058 529058
Branches 64617 64617
=========================================
+ Hits 92922 92936 +14
+ Misses 425683 425667 -16
- Partials 10453 10455 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| spy.prepareForMaintenance("static", false); | ||
| }); | ||
|
|
||
| Mockito.when(msHost.getState()).thenReturn(ManagementServerHost.State.PreparingForMaintenance); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check if ManagementServerMaintenanceManagerImpl::cancelMaintenanceTask() is taking the right path based on the ms host state, as these states are removed
nvazquez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM
shwstppr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm
@harikrishna-patnala Can you please check the comment for Suresh?
|
@blueorangutan package |
|
@borisstoyanov a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
|
packaging should suffice for this one |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16598 |
There are few test failures observed during build
Description
This PR...
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?