Skip to content

Conversation

@harikrishna-patnala
Copy link
Contributor

There are few test failures observed during build

12:29:49 [INFO] Running org.apache.cloudstack.maintenance.ManagementServerMaintenanceManagerImplTest
12:29:53 [ERROR] Tests run: 34, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 4.309 s <<< FAILURE! - in org.apache.cloudstack.maintenance.ManagementServerMaintenanceManagerImplTest
12:29:53 [ERROR] unnecessary Mockito stubbings(org.apache.cloudstack.maintenance.ManagementServerMaintenanceManagerImplTest)  Time elapsed: 0.037 s  <<< ERROR!
12:29:53 org.mockito.exceptions.misusing.UnnecessaryStubbingException: 
12:29:53 
12:29:53 Unnecessary stubbings detected in test class: ManagementServerMaintenanceManagerImplTest
12:29:53 Clean & maintainable test code requires zero unnecessary code.
12:29:53 Following stubbings are unnecessary (click to navigate to relevant line of code):
12:29:53   1. -> at org.apache.cloudstack.maintenance.ManagementServerMaintenanceManagerImplTest.prepareForMaintenanceAndCancelFromMaintenanceState(ManagementServerMaintenanceManagerImplTest.java:324)
12:29:53   2. -> at org.apache.cloudstack.maintenance.ManagementServerMaintenanceManagerImplTest.prepareForMaintenanceAndCancelFromPreparingForMaintenanceState(ManagementServerMaintenanceManagerImplTest.java:342)
12:29:53 Please remove unnecessary stubbings or use 'lenient' strictness. More info: javadoc for UnnecessaryStubbingException class.
12:29:53 

Description

This PR...

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov
Copy link

codecov bot commented Oct 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.56%. Comparing base (2dbc86a) to head (d7930aa).
⚠️ Report is 262 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main   #11914   +/-   ##
=========================================
  Coverage     17.56%   17.56%           
+ Complexity    15542    15538    -4     
=========================================
  Files          5909     5909           
  Lines        529058   529058           
  Branches      64617    64617           
=========================================
+ Hits          92922    92936   +14     
+ Misses       425683   425667   -16     
- Partials      10453    10455    +2     
Flag Coverage Δ
uitests 3.58% <ø> (ø)
unittests 18.63% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

spy.prepareForMaintenance("static", false);
});

Mockito.when(msHost.getState()).thenReturn(ManagementServerHost.State.PreparingForMaintenance);
Copy link
Contributor

@sureshanaparti sureshanaparti Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check if ManagementServerMaintenanceManagerImpl::cancelMaintenanceTask() is taking the right path based on the ms host state, as these states are removed

Copy link
Contributor

@nvazquez nvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@harikrishna-patnala Can you please check the comment for Suresh?

@DaanHoogland DaanHoogland added this to the 4.23.0 milestone Jan 28, 2026
@borisstoyanov
Copy link
Contributor

@blueorangutan package

@borisstoyanov borisstoyanov self-assigned this Jan 28, 2026
@blueorangutan
Copy link

@borisstoyanov a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

@DaanHoogland
Copy link
Contributor

packaging should suffice for this one

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16598

@DaanHoogland DaanHoogland merged commit 106f478 into apache:main Jan 28, 2026
27 checks passed
@DaanHoogland DaanHoogland deleted the removeUnnecessaryStubbings branch January 28, 2026 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants