Skip to content

Conversation

@DaanHoogland
Copy link
Contributor

Description

This PR fixes a label mismatch

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@github-actions
Copy link

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@DaanHoogland DaanHoogland changed the base branch from main to 4.20 October 22, 2025 13:48
@DaanHoogland DaanHoogland force-pushed the missingOfferingUpdateMessage branch from d1da772 to ef390b2 Compare October 22, 2025 13:50
@DaanHoogland DaanHoogland added this to the 4.20.3 milestone Oct 22, 2025
@DaanHoogland DaanHoogland marked this pull request as ready for review October 22, 2025 13:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR corrects a message ID mismatch in localization files. The message key for "Changing offering for the volume..." was incorrectly named message.change.offering.processing and has been updated to message.change.offering.for.volume.processing to align with related message keys and its actual usage context.

Key Changes:

  • Renamed message ID from message.change.offering.processing to message.change.offering.for.volume.processing in English localization
  • Reordered Chinese localization entry to maintain consistent line numbering with the English file

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
ui/public/locales/en.json Updated message key to include .for.volume suffix for consistency with related volume operation messages
ui/public/locales/zh_CN.json Reordered message entry to align with English file structure

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 16.24%. Comparing base (ff0cfc9) to head (7055dca).
⚠️ Report is 2 commits behind head on 4.20.

Additional details and impacted files
@@            Coverage Diff            @@
##               4.20   #11890   +/-   ##
=========================================
  Coverage     16.24%   16.24%           
- Complexity    13396    13398    +2     
=========================================
  Files          5658     5658           
  Lines        499246   499246           
  Branches      60599    60599           
=========================================
+ Hits          81096    81100    +4     
+ Misses       409106   409102    -4     
  Partials       9044     9044           
Flag Coverage Δ
uitests 4.03% <ø> (ø)
unittests 17.10% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

"label.edit.traffic.type": "ట్రాఫిక్ రకాన్ని సవరించండి",
"label.edit.user": "వినియోగదారుని సవరించండి",
"label.egress": "ఎగ్రెస్",
"label.egress.rule": "ఎగ్రెస్ పాలన",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DaanHoogland It's great to see the Telugu i18n for the Cloud Stack! I noticed a word where the translations aren't quite the right fit. It appears the system picked synonyms instead of the exact, intended word translations for those terms. Rule supposed to be 'నియమం' not 'పాలన' [ It means Govern ]. "ఎగ్రెస్ నియమం" is correct word :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pavanaravapalli , I only speak west-west-indo-european ;) so please feel free to add a PR to change it. I know of only one person involved in the Telugu translation so far and will ask him (@kiranchavala ) to review it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(P.S. happy to play arbiter on your linguistic debates ;)

@abh1sar
Copy link
Collaborator

abh1sar commented Oct 24, 2025

@sureshanaparti was it intended to have te.json in this change?
I think it is already present in 4.21

@DaanHoogland
Copy link
Contributor Author

@sureshanaparti was it intended to have te.json in this change? I think it is already present in 4.21

@abh1sar , the reason I am including it is because the fix applies to it and will be overlooked otherwise. Happy to take it out and lay the maintenance burden on Telugu maintainers.

Copy link
Collaborator

@abh1sar abh1sar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaanHoogland DaanHoogland force-pushed the missingOfferingUpdateMessage branch from ef390b2 to e5543c6 Compare December 8, 2025 15:55
@DaanHoogland
Copy link
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11890 (QA-JID-822)

@DaanHoogland
Copy link
Contributor Author

@kiranchavala , can you have another look, please?

@DaanHoogland DaanHoogland force-pushed the missingOfferingUpdateMessage branch from e5543c6 to 0ded10f Compare December 23, 2025 19:47
@DaanHoogland
Copy link
Contributor Author

@kiranchavala , can you have another look, please?

@kiranchavala ping

@DaanHoogland DaanHoogland removed the request for review from kiranchavala January 27, 2026 08:19
@DaanHoogland DaanHoogland force-pushed the missingOfferingUpdateMessage branch from 0ded10f to 7055dca Compare January 27, 2026 08:21
@DaanHoogland
Copy link
Contributor Author

@pavanaravapalli @kiranchavala @abh1sar , please ping me if you feel this must still go in. I feel that after some rebases, it no longer hold value (except for backporting the telugu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants