-
Notifications
You must be signed in to change notification settings - Fork 1.3k
ui: introduce section-level “advisories” with quick-fix actions #11763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This change adds a lightweight “advisories” mechanism to section configs and ships the first advisory to help operators satisfy some of the CKS prerequisites. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11763 +/- ##
============================================
- Coverage 17.85% 17.85% -0.01%
- Complexity 16000 16002 +2
============================================
Files 5930 5932 +2
Lines 531439 531592 +153
Branches 64970 64989 +19
============================================
+ Hits 94883 94898 +15
- Misses 425932 426068 +136
- Partials 10624 10626 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
|
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
|
UI build: ✔️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a lightweight "advisories" mechanism to section configurations that displays warnings and quick-fix actions to help operators satisfy CKS (CloudStack Kubernetes Service) prerequisites. The feature adds advisory alerts with actionable buttons to guide users through common configuration issues.
- Adds advisory system with condition evaluation and quick-fix actions
- Implements three CKS-specific advisories for compute offerings, Kubernetes versions, and endpoint URL configuration
- Provides dismissible alerts with primary/secondary action buttons
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| ui/src/views/AutogenView.vue | Integrates AdvisoriesView component into the main view |
| ui/src/config/section/compute.js | Adds three CKS advisories with conditions and fix actions |
| ui/src/config/router.js | Extends router metadata to include advisories configuration |
| ui/src/components/view/AdvisoriesView.vue | Core advisory component with alert rendering and action handling |
| ui/src/api/index.js | Adds getBaseUrl utility function |
| ui/public/locales/en.json | Adds localization strings for advisory messages and actions |
Comments suppressed due to low confidence (1)
ui/src/components/view/AdvisoriesView.vue:1
- Use 'const' instead of 'var' for variable declaration to follow modern JavaScript best practices and maintain consistency with the rest of the codebase.
// Licensed to the Apache Software Foundation (ASF) under one
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
|
cool idea! |
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
|
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
DaanHoogland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good overall
| filters: child.filters, | ||
| params: child.params ? child.params : {}, | ||
| columns: child.columns, | ||
| advisories: !vueProps.$config.advisoriesDisabled ? child.advisories : undefined, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bit of a nitpick, but I would reverse the setting, i.e. advisoriesEnabled (default true)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DaanHoogland can be done but I'm not sure if everyone would want it so kept it disabled by default
|
@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 16576 |
sudo87
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, tested it
|
@blueorangutan package |
|
@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
Pearl1594
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice stuff! code lgtm. Also tested it.
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 16601 |
|
@kiranchavala a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
borisstoyanov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This change adds a lightweight “advisories” mechanism to section configs and ships the first advisory to help operators satisfy some of the CKS prerequisites.
The functionality can be disabled by adding
advisoriesDisabledastruein config.json.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
ui-feature-advisory.mp4
How Has This Been Tested?
How did you try to break this feature and the system with this change?