Skip to content

cleanup LDAP code according to warnings #11436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DaanHoogland merged 4 commits into from
Dec 18, 2025

Merge branch 'main' into ldapCleanup

2983839
Select commit
Loading
Failed to load commit list.
Merged

cleanup LDAP code according to warnings #11436

Merge branch 'main' into ldapCleanup
2983839
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 17, 2025 in 1s

17.50% (+13.91%) compared to 2ac2e5b

View this Pull Request on Codecov

17.50% (+13.91%) compared to 2ac2e5b

Details

Codecov Report

❌ Patch coverage is 41.17647% with 110 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.50%. Comparing base (2ac2e5b) to head (2983839).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...va/org/apache/cloudstack/ldap/LdapManagerImpl.java 0.00% 52 Missing ⚠️
...pache/cloudstack/ldap/OpenLdapUserManagerImpl.java 5.88% 16 Missing ⚠️
.../org/apache/cloudstack/ldap/LdapConfiguration.java 74.35% 9 Missing and 1 partial ⚠️
...org/apache/cloudstack/ldap/LdapContextFactory.java 0.00% 7 Missing ⚠️
.../org/apache/cloudstack/ldap/LdapAuthenticator.java 40.00% 5 Missing and 1 partial ⚠️
...che/cloudstack/api/command/LdapImportUsersCmd.java 58.33% 5 Missing ⚠️
...e/cloudstack/api/command/LinkAccountToLdapCmd.java 0.00% 3 Missing ⚠️
...oudstack/api/command/LdapListConfigurationCmd.java 0.00% 2 Missing ⚠️
...pache/cloudstack/api/command/LdapListUsersCmd.java 92.30% 1 Missing and 1 partial ⚠️
...ache/cloudstack/api/command/LdapUserSearchCmd.java 0.00% 2 Missing ⚠️
... and 4 more
Additional details and impacted files 
@@             Coverage Diff              @@
##              main   #11436       +/-   ##
============================================
+ Coverage     3.58%   17.50%   +13.91%     
- Complexity       0    15564    +15564     
============================================
  Files          445     5914     +5469     
  Lines        37571   529642   +492071     
  Branches      6921    64702    +57781     
============================================
+ Hits          1347    92691    +91344     
- Misses       36058   426503   +390445     
- Partials       166    10448    +10282

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov