Update templateConfig.sh to not break with directorys with space on t… by vits-hugs · Pull Request #10898 · apache/cloudstack

vits-hugs · 2025-05-20T17:45:36Z

Description

Currently the script of templateConfig.sh doesn't recognize folders with spaces in their names, which can cause compilation errors, this PR updates the script so that the folders with space in their names are recognized.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

To test this, I renamed my user folder to have a white-space in it, then ran the process of building the project, which runs the templateConfig.sh, and verified that there wasn't any errors on the building process.

engine/schema/templateConfig.sh

codecov · 2025-05-23T18:12:29Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 16.23%. Comparing base (e8200a0) to head (1a19059).
⚠️ Report is 3 commits behind head on 4.20.

Additional details and impacted files

@@            Coverage Diff            @@
##               4.20   #10898   +/-   ##
=========================================
  Coverage     16.23%   16.23%           
- Complexity    13371    13373    +2     
=========================================
  Files          5657     5657           
  Lines        498860   498860           
  Branches      60543    60543           
=========================================
  Hits          81003    81003           
+ Misses       408824   408823    -1     
- Partials       9033     9034    +1

Flag	Coverage Δ
uitests	`4.00% <ø> (ø)`
unittests	`17.09% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

JoaoJandre · 2025-06-02T20:05:08Z

@blueorangutan package

blueorangutan · 2025-06-02T20:06:07Z

@JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-06-02T21:23:35Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 13586

engine/schema/templateConfig.sh

weizhouapache · 2025-08-22T08:13:56Z

@vits-hugs
can you have a look at comments above ?

DaanHoogland · 2025-12-12T10:01:26Z

@vits-hugs, do you still want to move this forwards?

hsato03 · 2025-12-18T19:52:47Z

@vits-hugs, do you still want to move this forwards?

@DaanHoogland Yes. Since @vits-hugs is no longer maintaining the PR, I will be working on it.

@weizhouapache I have applied your suggestions. Could you take another look and check if all your concerns have been addressed, please?

hsato03 · 2025-12-18T19:52:58Z

@blueorangutan package

blueorangutan · 2025-12-18T19:54:03Z

@hsato03 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-12-18T19:54:58Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 16089

weizhouapache · 2025-12-19T08:11:54Z

@blueorangutan package

weizhouapache

code lgtm

github-actions · 2025-12-19T08:19:11Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

weizhouapache · 2025-12-19T08:24:58Z

@hsato03
I changed the target branch to 4.20, as 4.19 is not maintained
can you fix the conflicts ?

…he names

Address Wei's reviews Co-authored-by: Wei Zhou <weizhou@apache.org>

hsato03 · 2025-12-19T14:01:24Z

@weizhouapache Sure. I resolved the conflicts and reproduced the tests described in the PR; it seems to be working fine.

weizhouapache · 2025-12-19T14:03:45Z

@weizhouapache Sure. I resolved the conflicts and reproduced the tests described in the PR; it seems to be working fine.

@hsato03
good, thanks for the update

weizhouapache · 2025-12-19T14:03:49Z

@blueorangutan package

blueorangutan · 2025-12-19T14:06:03Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-12-19T14:53:06Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 16107

weizhouapache · 2025-12-19T15:27:20Z

@blueorangutan package

blueorangutan · 2025-12-19T15:28:04Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-12-19T16:14:29Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 16108

DaanHoogland · 2025-12-20T09:15:29Z

@blueorangutan test

blueorangutan · 2025-12-20T09:16:04Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

DaanHoogland

clgtm

blueorangutan · 2025-12-20T23:32:14Z

[SF] Trillian test result (tid-15034)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 48794 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10898-t15034-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

DaanHoogland · 2025-12-21T09:22:20Z

going on a limb here and assuming no 3rd party testing is needed (given the extend of the changes and the author described their testing)

* 4.22: Update templateConfig.sh to not break with directorys with space on t… (#10898) Fix VM and volume metrics listing regressions (#12284) packaging: use latest cmk release link directly (#11429) api:rename RegisterCmd.java => RegisterUserKeyCmd.java (#12259) Prioritize copying templates from other secondary storages instead of downloading them (#10363) Show time correctly in the backup schedule UI (#12012) kvm: use preallocation option for fat disk resize (#11986) Python exception processing static routes fixed (#11967) KVM memballooning requires free page reporting and autodeflate (#11932) api: create/register/upload template with empty template tag (#12234)

apache#10898) Co-authored-by: Vitor Hugo Homem Marzarotto <vitor.marzarotto@scclouds.com.br> Co-authored-by: Henrique Sato <henriquesato2003@gmail.com> Co-authored-by: Wei Zhou <weizhou@apache.org>

weizhouapache reviewed May 20, 2025

View reviewed changes

engine/schema/templateConfig.sh Outdated Show resolved Hide resolved

DaanHoogland force-pushed the 4.19 branch from 8ef8b46 to 857ccb0 Compare May 27, 2025 14:19

DaanHoogland added this to the 4.19.4 milestone Jun 3, 2025

weizhouapache reviewed Aug 18, 2025

View reviewed changes

engine/schema/templateConfig.sh Outdated Show resolved Hide resolved

engine/schema/templateConfig.sh Outdated Show resolved Hide resolved

engine/schema/templateConfig.sh Outdated Show resolved Hide resolved

weizhouapache modified the milestones: 4.19.4, 4.20.2 Sep 2, 2025

weizhouapache modified the milestones: 4.20.2, 4.20.3 Sep 10, 2025

weizhouapache reviewed Dec 19, 2025

View reviewed changes

weizhouapache changed the base branch from 4.19 to 4.20 December 19, 2025 08:12

weizhouapache approved these changes Dec 19, 2025

View reviewed changes

github-actions bot added the status:has-conflicts label Dec 19, 2025

Vitor Hugo Homem Marzarotto and others added 2 commits December 19, 2025 10:20

Update templateConfig.sh to not break with directorys with space on t…

c6eeb75

…he names

Apply suggestions from code review

1a19059

Address Wei's reviews Co-authored-by: Wei Zhou <weizhou@apache.org>

hsato03 force-pushed the corrects-template.sh branch from fcabb0c to 1a19059 Compare December 19, 2025 13:21

github-actions bot removed the status:has-conflicts label Dec 19, 2025

DaanHoogland approved these changes Dec 20, 2025

View reviewed changes

DaanHoogland merged commit 47a6ac8 into apache:4.20 Dec 21, 2025
24 of 26 checks passed

Conversation

vits-hugs commented May 20, 2025

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

Uh oh!

codecov bot commented May 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

JoaoJandre commented Jun 2, 2025

Uh oh!

blueorangutan commented Jun 2, 2025

Uh oh!

blueorangutan commented Jun 2, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

weizhouapache commented Aug 22, 2025

Uh oh!

DaanHoogland commented Dec 12, 2025

Uh oh!

hsato03 commented Dec 18, 2025

Uh oh!

hsato03 commented Dec 18, 2025

Uh oh!

blueorangutan commented Dec 18, 2025

Uh oh!

blueorangutan commented Dec 18, 2025

Uh oh!

weizhouapache commented Dec 19, 2025

Uh oh!

weizhouapache left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 19, 2025

Uh oh!

weizhouapache commented Dec 19, 2025

Uh oh!

hsato03 commented Dec 19, 2025

Uh oh!

weizhouapache commented Dec 19, 2025

Uh oh!

weizhouapache commented Dec 19, 2025

Uh oh!

blueorangutan commented Dec 19, 2025

Uh oh!

blueorangutan commented Dec 19, 2025

Uh oh!

weizhouapache commented Dec 19, 2025

Uh oh!

blueorangutan commented Dec 19, 2025

Uh oh!

blueorangutan commented Dec 19, 2025

Uh oh!

DaanHoogland commented Dec 20, 2025

Uh oh!

blueorangutan commented Dec 20, 2025

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Dec 20, 2025

Uh oh!

DaanHoogland commented Dec 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov bot commented May 23, 2025 •

edited

Loading