Skip to content

Fix assert failure triggered by "CREATE INDEX CONCURRENTLY" #1845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fairyfar wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −33
Open

Fix assert failure triggered by "CREATE INDEX CONCURRENTLY" #1845

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 11 additions & 33 deletions src/backend/commands/resgroupcmds.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -715,47 +715,25 @@ GetResGroupIdForRole(Oid roleid)
{
HeapTuple tuple;
Oid groupId;
bool isNull;
Relation rel;
ScanKeyData key;
SysScanDesc sscan;

rel = table_open(AuthIdRelationId, AccessShareLock);

ScanKeyInit(&key,
Anum_pg_authid_oid,
BTEqualStrategyNumber, F_OIDEQ,
ObjectIdGetDatum(roleid));

sscan = systable_beginscan(rel, AuthIdOidIndexId, true, NULL, 1, &key);
bool isNull = true;

tuple = systable_getnext(sscan);
/*
* Prefer syscache lookup to avoid taking explicit catalog scan/snapshot
* which may install xmin in the current process. Use the AUTHOID
* syscache to fetch pg_authid tuple for the given role Oid.
*/
tuple = SearchSysCache1(AUTHOID, ObjectIdGetDatum(roleid));

@yjhjstz yjhjstz Jul 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add related test create index concurrently t_idx on t(a, b); ?

if (!HeapTupleIsValid(tuple))
{
systable_endscan(sscan);
table_close(rel, AccessShareLock);

/*
* Role should have been dropped by other backends in this case, so this
* session cannot execute any command anymore
*/
ereport(ERROR,
(errcode(ERRCODE_UNDEFINED_OBJECT),
errmsg("role with Oid %u was dropped", roleid),
errdetail("Cannot execute commands anymore, please terminate this session.")));
errmsg("role with Oid %u was dropped", roleid),
errdetail("Cannot execute commands anymore, please terminate this session.")));
}

/* must access tuple before systable_endscan */
groupId = DatumGetObjectId(heap_getattr(tuple, Anum_pg_authid_rolresgroup,
rel->rd_att, &isNull));
groupId = DatumGetObjectId(SysCacheGetAttr(AUTHOID, tuple, Anum_pg_authid_rolresgroup, &isNull));

systable_endscan(sscan);

/*
* release lock here to guarantee we have no lock held when acquiring
* resource group slot
*/
table_close(rel, AccessShareLock);
ReleaseSysCache(tuple);

if (!OidIsValid(groupId))
groupId = InvalidOid;
Expand Down
Loading