[CELEBORN-2242] PushMergedData RPC supports compatible with low version Server#3573
[CELEBORN-2242] PushMergedData RPC supports compatible with low version Server#3573cxzl25 wants to merge 2 commits intoapache:mainfrom
Conversation
| new RpcResponseCallback() { | ||
| @Override | ||
| public void onSuccess(ByteBuffer response) { | ||
| // Compatible with lower versions of Server |
There was a problem hiding this comment.
could you please add more detail info here? e.g., JIRA tickets, versions, and why it can be treated as success
|
Celeborn’s release policy is that the server remains compatible with clients from the previous major version for easy user upgrades. If we also commit to ensuring that higher-version clients are compatible with lower-version servers, we would have to ensure every client-side change is compatiable on older servers. This would make development, code review, and releases significantly more difficult. Personally, I suggest that we should not maintain backward compatibility of higher-version clients with lower-version servers. cc @cxzl25 @turboFei @pan3793 |
I agree with you. @RexXiong |
What changes were proposed in this pull request?
Why are the changes needed?
A client that supports HARD_SPLIT in PushMergedData will report the following error when accessing a lower version of the Server.
Does this PR resolve a correctness bug?
Does this PR introduce any user-facing change?
How was this patch tested?
local test