CAUSEWAY-3752: provide SPI to describe which classes are surfaced by the different viewers #3264
+2,994
−3,288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plus some refactoring
introduces WhatViewer for filtering t.b. done later
InteractionConstraint
InteractionConstraint (2)
andi-huber
commented
Dec 3, 2025
|
|
||
| return property.isVisible(owner, InteractionInitiatedBy.FRAMEWORK, getWhere()).isAllowed() | ||
| && property.isVisible(owner, InteractionInitiatedBy.USER, getWhere()).isAllowed() | ||
| return property.isVisible(owner, iConstraint().withInitiatedBy(InteractionInitiatedBy.FRAMEWORK)).isAllowed() //TODO strange API |
Contributor
Author
There was a problem hiding this comment.
this is the only place where we ask framework and user visibility;
how is this justified?
andi-huber
commented
Dec 3, 2025
| RenderPolicy renderPolicy) | ||
| implements VisibilityContext { | ||
|
|
||
| // public CollectionVisibilityContext( |
Contributor
Author
There was a problem hiding this comment.
if ultimately not needed, remove
andi-huber
commented
Dec 3, 2025
Comment on lines
+75
to
+79
| property.isVisible(rowElement(), iConstraint).isAllowed() //TODO API: should not be required | ||
| ? property.get(rowElement(), interactionInitiatedBy) | ||
| : ManagedObject.empty(property.getElementType())), | ||
| collection-> ManagedObjects.unpack( | ||
| collection.isVisible(rowElement(), interactionInitiatedBy, Where.ALL_TABLES).isAllowed() | ||
| collection.isVisible(rowElement(), iConstraint).isAllowed() //TODO API: should not be required |
Contributor
Author
There was a problem hiding this comment.
confusing:
we are checking whether a property is visible, constraint by WhatViewer and Where, but then use path-through, ignoring user access constraints to get the property.
andi-huber
commented
Dec 3, 2025
Comment on lines
+54
to
+61
| || property.isVisible(rowElement(), iConstraint).isAllowed() //TODO API: should not be required | ||
| ? property.get(rowElement(), interactionInitiatedBy) | ||
| : ManagedObject.empty(property.getElementType())), | ||
| collection-> ManagedObjects.unpack( | ||
| interactionInitiatedBy.isPassThrough() | ||
| || collection.isVisible(rowElement(), interactionInitiatedBy, Where.ALL_TABLES).isAllowed() | ||
| ? collection.get(rowElement(), interactionInitiatedBy) | ||
| : null | ||
| || collection.isVisible(rowElement(), iConstraint).isAllowed() //TODO API: should not be required | ||
| ? collection.get(rowElement(), interactionInitiatedBy) | ||
| : null |
Contributor
Author
There was a problem hiding this comment.
same as in DataRowInternal, confusing:
we are checking whether a property is visible, constraint by WhatViewer and Where, but then use path-through, ignoring user access constraints to get the property
andi-huber
commented
Dec 3, 2025
Comment on lines
+49
to
+60
| @Override | ||
| public void process(final ProcessClassContext processClassContext) { | ||
| var facetHolder = processClassContext.getFacetHolder(); | ||
| //TODO WIP FacetUtil.addFacet(new HiddenFacetForFeatureFilterImpl(facetHolder)); | ||
| } | ||
|
|
||
| @Override | ||
| public void process(final ProcessMethodContext processMethodContext) { | ||
| var facetHolder = processMethodContext.getFacetHolder(); | ||
| //TODO WIP processMethodContext.getFeatureType().isProperty(); | ||
| //TODO WIP FacetUtil.addFacet(new HiddenFacetForFeatureFilterImpl(facetHolder)); | ||
| } |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ProtoypeFacet