CASSSIDECAR-343: Sidecar endpoint for flushing a node #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankgh
reviewed
Oct 1, 2025
JeetKunDoug
reviewed
Oct 3, 2025
Contributor
There was a problem hiding this comment.
Please remove this class file (not sure how it landed here)
arjunashok
reviewed
Oct 3, 2025
| /** | ||
| * Integration tests for node flush operation | ||
| */ | ||
| public class NodeFlushIntegrationTest extends SharedClusterSidecarIntegrationTestBase |
Contributor
There was a problem hiding this comment.
Can we validate that an actual flush operation was triggered/performed on Cassandra? One option worth evaluating would be to validate the memtable size/count around the flush operation.
arjunashok
reviewed
Oct 3, 2025
Contributor
arjunashok
left a comment
arjunashok
left a comment
There was a problem hiding this comment.
Please also add Changes.txt entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sidecar endpoint for flushing a node
These changes are part of the effort to introduce bespoke Sidecar APIs to support key operational functionality currently managed through nodetool commands. Changes in the commit: