Skip to content

CASSCPP-3 Crash on Pure virtual function while the destructor of the Session object is called #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
absurdfarce wants to merge 1 commit into
base: trunk
Choose a base branch
from
+1 −3
Open

CASSCPP-3 Crash on Pure virtual function while the destructor of the Session object is called #583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/connection.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ class ConnectionListener {
*
* @param connection The closing connection.
*/
virtual void on_close(Connection* connection) = 0;
virtual void on_close(Connection* connection) {};
Copy link

@yifan-c yifan-c Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the tailing ; is redundant.

};

/**
Expand Down
2 changes: 0 additions & 2 deletions src/prepare_host_handler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,6 @@ void PrepareHostHandler::prepare(uv_loop_t* loop, const ConnectionSettings& sett
}

void PrepareHostHandler::on_close(Connection* connection) {
callback_(this);
Copy link
Contributor Author

@absurdfarce absurdfarce Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Long-term the better answer is probably to not make HOST_UP/HOST_READY/HOST_ADD event distribution a function of the callback in use here. Those ops should be handled by logic in the relevant functions of cluster.cpp, specifically as some kind of "after" action from the prepare op. But this fix allows us to address the immediate problem without having to refactor the entirety of message delivery.

Copy link

@yifan-c yifan-c Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sharing the context. Shall we comment the todo in the code?


dec_ref(); // The event loop is done with this handler
}

Expand Down