Skip to content

Conversation

@dkropachev
Copy link
Contributor

@dkropachev dkropachev commented Dec 7, 2025

distutils.version is getting depricated, we need to move off it.

Fixes: #774

@dkropachev
Copy link
Contributor Author

@michaelsembwever , could you please take a look at it

@dkropachev dkropachev force-pushed the dk/move-off-distutils-version branch from 53bf85d to ad802cd Compare December 14, 2025 12:04
@dkropachev
Copy link
Contributor Author

@michaelsembwever , could you please take a look at it

CICD failed, i have fixed it.

@michaelsembwever
Copy link
Member

michaelsembwever commented Dec 14, 2025

another failure, this time between deps: https://pre-ci.cassandra.apache.org/job/cassandra-5.0/53/pipeline-overview/?start-byte=0&selected-node=1594#log-1594-75

16:02:20  INFO: pip is still looking at multiple versions of ccm to determine which version is compatible with other requirements. This could take a while.
16:02:20  ERROR: Cannot install -r /home/cassandra/cassandra-dtest/requirements.txt (line 12), -r /home/cassandra/cassandra-dtest/requirements.txt (line 31) and packaging==21.3 because these package versions have conflicting dependencies.
16:02:20  
16:02:20  The conflict is caused by:
16:02:20      The user requested packaging==21.3
16:02:20      pytest 7.0.1 depends on packaging
16:02:20      ccm 3.1.6.dev1345 depends on packaging<21
16:02:20  
16:02:20  To fix this you could try to:
16:02:20  1. loosen the range of package versions you've specified

(same on this PR: i'd like to test it on top of #801 )

@michaelsembwever
Copy link
Member

#801 is merged, please rebase and (force) push.

distutils.version is getting depricated, we need to move off it.
@dkropachev dkropachev force-pushed the dk/move-off-distutils-version branch from ad802cd to a067640 Compare December 20, 2025 17:37
@dkropachev
Copy link
Contributor Author

#801 is merged, please rebase and (force) push.

Done, it is green.

@michaelsembwever
Copy link
Member

@michaelsembwever
Copy link
Member

michaelsembwever commented Dec 22, 2025

https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch-before-5-dtest/42/ – same failure as on 5.0 #799 (comment)

@dkropachev , if i patch thelastpickle/cassandra-dtest@aada32c) so requirements.txt to also packaging<21
it fixes the failures: http://ci-cassandra.infra.datastax.com/job/cassandra-5.0/61/

This includes applying the same change of LooseVersion in all of cassandra-dtest, something that needs to be done for CASSANDRA-18321.

Unfortunately, this changes a compatibility breakage (complicated because both cassandra-dtest and cassandra-ccm are used unpinned). This will be documented.

But it means I will need to merge both this PR and the cassandra-test PR at the same time, and I'm waiting on a review on the latter:

@dkropachev
Copy link
Contributor Author

dkropachev commented Dec 22, 2025

https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch-before-5-dtest/42/ – same failure as on 5.0 #799 (comment)

@dkropachev , if i patch thelastpickle/cassandra-dtest@aada32c) so requirements.txt to also packaging<21
it fixes the failures: http://ci-cassandra.infra.datastax.com/job/cassandra-5.0/61/

This includes applying the same change of LooseVersion in all of cassandra-dtest, something that needs to be done for CASSANDRA-18321.

Unfortunately, this changes a compatibility breakage (complicated because both cassandra-dtest and cassandra-ccm are used unpinned). This will be documented.

But it means I will need to merge both this PR and the cassandra-test PR at the same time, and I'm waiting on a review on the latter:

Not really, you can pin ccm in dtest and then merge this guy and then make pr to move to new ccm commit or back to master on dtest.
Of course back porting to all the dtest branches

@michaelsembwever
Copy link
Member

Not really, you can pin ccm in dtest and then merge this guy and then make pr to move to new ccm commit or back to master on dtest.
Of course back porting to all the dtest branches

Conflating the issue a bit more…
I can only see that working if we fixed the cassandra-test tag to where it currently was and moved on to a new tag.
If we pinned it to something else then that's only applying from that sha that has the pin, all previous shas are still referencing cassandra-test.

I'm ok with not doing anything about it, as explained in https://issues.apache.org/jira/browse/CASSANDRA-18321?focusedCommentId=18046997&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-18046997

As neither are pinned anywhere (where they are used in combination) nothing will be done about this.

🤷

@michaelsembwever
Copy link
Member

@dkropachev , this PR and #798
is still blocked on a review of apache/cassandra-dtest#283

#283 is simply redoing what you have done in this PR in the cassandra-dtest repo. I don't need a "you're responsible" review, just a second pair of anyone's eyeballs and you'll be perfect :)

@dkropachev
Copy link
Contributor Author

@dkropachev , this PR and #798 is still blocked on a review of apache/cassandra-dtest#283

#283 is simply redoing what you have done in this PR in the cassandra-dtest repo. I don't need a "you're responsible" review, just a second pair of anyone's eyeballs and you'll be perfect :)

I have reviewed it.

@michaelsembwever
Copy link
Member

committed as 27e46a1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

distutils Version classes are deprecated. Use packaging.version instead.

2 participants