-
Notifications
You must be signed in to change notification settings - Fork 308
Replace distutils.version with custom implementation #799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@michaelsembwever , could you please take a look at it |
53bf85d to
ad802cd
Compare
CICD failed, i have fixed it. |
|
another failure, this time between deps: https://pre-ci.cassandra.apache.org/job/cassandra-5.0/53/pipeline-overview/?start-byte=0&selected-node=1594#log-1594-75 (same on this PR: i'd like to test it on top of #801 ) |
|
#801 is merged, please rebase and (force) push. |
distutils.version is getting depricated, we need to move off it.
ad802cd to
a067640
Compare
Done, it is green. |
|
CI
|
@dkropachev , if i patch thelastpickle/cassandra-dtest@aada32c) so This includes applying the same change of Unfortunately, this changes a compatibility breakage (complicated because both cassandra-dtest and cassandra-ccm are used unpinned). This will be documented. But it means I will need to merge both this PR and the cassandra-test PR at the same time, and I'm waiting on a review on the latter: |
Not really, you can pin ccm in dtest and then merge this guy and then make pr to move to new ccm commit or back to master on dtest. |
Conflating the issue a bit more… I'm ok with not doing anything about it, as explained in https://issues.apache.org/jira/browse/CASSANDRA-18321?focusedCommentId=18046997&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-18046997
🤷 |
|
@dkropachev , this PR and #798 #283 is simply redoing what you have done in this PR in the cassandra-dtest repo. I don't need a "you're responsible" review, just a second pair of anyone's eyeballs and you'll be perfect :) |
I have reviewed it. |
|
committed as 27e46a1 |
distutils.version is getting depricated, we need to move off it.
Fixes: #774