-
Notifications
You must be signed in to change notification settings - Fork 29
CASSANALYTICS-42 Add S3-backed Cassandra batch reader #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
liucao-dd
wants to merge
10
commits into
apache:trunk
Choose a base branch
from
liucao-dd:s3-batch-reader-on-trunk
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+10,216
−86
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
ba73508
Add S3 reader configuration foundations
liucao-dd d8807ca
Add S3 Cassandra data layer internals
liucao-dd 4007648
Expose S3 Cassandra through Spark SQL
liucao-dd f206cea
Cover S3 Cassandra reader behavior
liucao-dd 1257126
Publish VersionRunner via java-test-fixtures
liucao-dd eff3df2
Thread per-task Stats through BackupReader read calls
liucao-dd ea4ec81
Fix SSTableTokenBounds pruning across the Murmur3 wrap-around
liucao-dd 33a659f
Fix javadoc issues
liucao-dd af03d9a
Support authoritative Cassandra ring replicas
liucao-dd b03fc5c
Align added/modified OSS tests with AssertJ assertion style
liucao-dd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this code/comment fully accurate? I'm aware Statistics.db can mutate the repair metadata (repairedAt, pendingRepair) to avoid recompaction, and also the compaction level to avoid a full rewrite.
Summary.db appears to only mutate if there is a change in the index sample size (redistributeSummaries).
Filter.db I can't find any place where it mutates. I think it is immutable from the first flush.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, i think filter.db is theoretically immutable but there is a code path that re-writes it:
https://github.com/apache/cassandra/blob/45fa31b/src/java/org/apache/cassandra/io/sstable/format/SSTableReaderBuilder.java#L450
It should be very rare, and if I read the code correctly, it happens during live re-opens of an SSTable (startup, import, streaming receipt), and only when its Filter.db is missing or it has no ValidationMetadata.
So it is theoretically possible but most likely can be treated immutable.