[CALCITE-5929] Improve LogicalWindow print plan to add the constant value#5015
Merged
Conversation
mihaibudiu
reviewed
Jun 11, 2026
| return buf.toString(); | ||
| } | ||
|
|
||
| private static String expandBound(RexWindowBound bound, |
Contributor
There was a problem hiding this comment.
Please note that bounds may not be literals, but constant expressions. Please add a test case for that to make sure that this toString() does the right thing.
Member
Author
There was a problem hiding this comment.
Yes, thanks for the reminder, I added tests to cover this.
mihaibudiu
reviewed
Jun 13, 2026
| * to their values. Unlike {@link #toString()}, this is for display | ||
| * only and does not affect {@link #equals} or {@link #hashCode}. | ||
| * Constants can be literals or expressions (e.g., 5+5), and are expanded | ||
| * to their string representation for readability. */ |
Contributor
There was a problem hiding this comment.
they are not expanded for readability, they are expanded because they have to be shown.
You can remove the text after the last comma.
mihaibudiu
approved these changes
Jun 13, 2026
|
xuzifu666
added
the
LGTM-will-merge-soon
xiedeyantu
reviewed
Jun 13, 2026
| <Resource name="sql"> | ||
| <
Member
There was a problem hiding this comment.
I see the SQL and the execution plan here; this is what I wanted to see. I don't have any other questions for now.
xiedeyantu
approved these changes
Jun 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jira: https://issues.apache.org/jira/browse/CALCITE-5929