[CALCITE-7587] RelDecorrelator fails on correlated scalar subquery with ROW_NUMBER window function due to RexOver nullability mismatch#4998
Merged
Conversation
iwanttobepowerful
force-pushed
the
CALCITE-7587
branch
from
0e1778c to
131769c
Compare
| # Correlated scalar sub-query in the SELECT list that contains a window function. | ||
| # Decorrelation must add the correlation key to the window partition and preserve nullability | ||
| # of the OVER expression after pulling it above the left correlate. | ||
| SELECT e.ename, |
Contributor
Author
There was a problem hiding this comment.
iwanttobepowerful
force-pushed
the
CALCITE-7587
branch
from
131769c to
e820856
Compare
Contributor
|
This looks fine, but I my knowledge of the decorrelation algorithms is rather superficial, so if @suibianwanwank can weigh in we can be more confident. |
mihaibudiu
approved these changes
Jun 11, 2026
| @Override public RexNode visitOver(RexOver over) { | ||
| // Collect correlation fields that are referenced directly by the window | ||
| // expression. They need to be added to the window partition keys so that | ||
| // decorrelation does not widen the window computation scope. |
Contributor
There was a problem hiding this comment.
Could you show here a plan fragment before and after the rewrite?
iwanttobepowerful
force-pushed
the
CALCITE-7587
branch
2 times, most recently
from
0f597e5 to
6c35e62
Compare
…th ROW_NUMBER window function due to RexOver nullability mismatch
iwanttobepowerful
force-pushed
the
CALCITE-7587
branch
from
6c35e62 to
4fdb5c9
Compare
|
mihaibudiu
approved these changes
Jun 12, 2026
mihaibudiu
left a comment
mihaibudiu
left a comment
Contributor
There was a problem hiding this comment.
Feel free to merge it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CALCITE-7587