AVRO-4211: Java Schema Gen for Unions w/ Default Value#3709
Open
zakpayne8283 wants to merge 1 commit intoapache:mainfrom
Open
AVRO-4211: Java Schema Gen for Unions w/ Default Value#3709zakpayne8283 wants to merge 1 commit intoapache:mainfrom
zakpayne8283 wants to merge 1 commit intoapache:mainfrom
Conversation
…alue that isn't the first union element
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR addresses AVRO-4211. In Java, the IDLUtils does not generate Schemas correctly for fields which are unions and have a default value if the default value is not the first element in the union.
For example:
Will produce a Schema like
because
Void.classis the first element in the union.This change aligns the Java library with the current documentation:
Verifying this change
This change modified tests and can be verified as follows:
Modified
TestJacksonUtils.java, adding a union with default value matching the second element of the union to thetestToObject()test.Documentation